Bug 100274 - no way to build x11-wm/fv2m95-i18m without apm outside of BATCH mode
Summary: no way to build x11-wm/fv2m95-i18m without apm outside of BATCH mode
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ion-Mihai "IOnut" Tetcu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-14 08:10 UTC by TsurutaniNaoki
Modified: 2006-07-15 00:06 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description TsurutaniNaoki 2006-07-14 08:10:15 UTC
	I want to build x11-wm/fvwm95-i18n without APM support, and
	I want to build with as possible as little input.
	Defining "WITH_APM=no" in make argument does not disable APM support,
	for the value of the variable is not checked.

Fix: 

Here is a patch:
	--- Makefile.orig	Tue Jun  6 17:05:13 2006
	+++ Makefile	Fri Jul 14 15:52:49 2006
	@@ -41,9 +41,10 @@
	 SAMPLEDIR=	${PREFIX}/share/examples/fvwm95
	 KITDIR=		${WRKDIR}/${PKGNAME}-portKit
	
	-.if defined(WITH_APM)
	+.if defined(WITH_APM) && !defined(WITHOUT_APM)
	 ONLY_FOR_ARCHS=	i386
	 ONLY_FOR_ARCHS_REASON= apm.h is only in i386 system
	+.else
	 .endif
	
	 post-extract:
	@@ -53,7 +54,7 @@
	 	${CP} ${WRKDIR}/apmpatch/freebsd-menu.xpm ${WRKSRC}/mini-icons
	
	 pre-patch:
	-.if !defined(BATCH) && !defined(FOR_CDROM) && !defined(WITH_APM)
	+.if !defined(BATCH) && !defined(FOR_CDROM) && !defined(WITH_APM) && !defined(WITHOUT_APM)
	 	 @${ECHO} -n "Are you going to use APM handling? (y/n) ==> "
	 	@(read ans; \
	 	  case x"$$ans" in \
	@@ -68,7 +69,7 @@
	 	  esac)
	 .endif
	 post-patch:
	-.if defined(WITH_APM)
	+.if defined(WITH_APM) && !defined(WITHOUT_APM)
	 	@${CAT} ${WRKDIR}/apmpatch/fvwm95-2.0.43a-Autoconf.I18N.apmpatch \
	 	| ${PATCH} -d ${WRKSRC}
	 .endif
How-To-Repeat: 	% make WITH_APM=no
Comment 1 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2006-07-14 23:58:27 UTC
Responsible Changed
From-To: freebsd-ports-bugs->itetcu

I'll take it.
Comment 2 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2006-07-15 00:06:18 UTC
State Changed
From-To: open->closed

Port OPTIONified to fic the problem, but thanks for submitting this.