Bug 100928 - [games/openttd] Uncripple the Makefile and remove useless warnings when removing data directory
Summary: [games/openttd] Uncripple the Makefile and remove useless warnings when remov...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-27 20:20 UTC by Ed Schouten
Modified: 2006-11-29 23:00 UTC (History)
0 users

See Also:


Attachments
file.diff (1.34 KB, patch)
2006-07-27 20:20 UTC, Ed Schouten
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Schouten 2006-07-27 20:20:08 UTC
The current Makefile of the OpenTTD port is quite broken. There are
variable assignments inside make target definitions. This prevents you
from using the WITH_* switches.

The plist also has some @dirrm's that will cause warnings on deletion
when the user as the data files installed.

Fix: Apply the following patch:

%%%
How-To-Repeat: Try to compile OpenTTD with WITH_MIDI_PLAYER defined. This will fail.
Removing an installation of OpenTTD with the data files installed will
cause warnings.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-07-27 20:20:20 UTC
Responsible Changed
From-To: freebsd-ports-bugs->danfe

Over to maintainer
Comment 2 Dmitry Marakasov 2006-07-27 20:49:06 UTC
* Ed Schouten (ed@fxq.nl) wrote:
> The plist also has some @dirrm's that will cause warnings on deletion
> when the user as the data files installed.
@dirrm's should stay, since warnings are absolutely correct. These will
also remind you that data should be deleted when removing openttd.

-- 
Best regards,
 Dmitry                          mailto:amdmi3@mail.ru
Comment 3 Pav Lucistnik freebsd_committer freebsd_triage 2006-11-29 22:43:23 UTC
State Changed
From-To: open->closed

Committed Makefile part, thanks. 
I agree the pkg-plist change is undesirable.
Comment 4 dfilter service freebsd_committer freebsd_triage 2006-11-29 22:58:10 UTC
pav         2006-11-29 22:56:41 UTC

  FreeBSD ports repository

  Modified files:
    games/openttd        Makefile 
  Added files:
    games/openttd/files  pkg-message.in 
  Removed files:
    games/openttd        pkg-message 
  Log:
  - Fix WITH_MIDI_PLAYER option (mixing of variable assignments and targets)
  
  PR:             ports/100928
  Submitted by:   Ed Schouten <ed@fxq.nl>
  Approved by:    maintainer timeout (4 months)
  
  - Add desktop entry
  
  PR:             ports/104069
  Submitted by:   Pawel Pekala <c0rn@o2.pl>
  Approved by:    maintainer timeout (1,5 month)
  
  - Modernize pkg-message handling, style
  
  Revision  Changes    Path
  1.12      +22 -17    ports/games/openttd/Makefile
  1.1       +16 -0     ports/games/openttd/files/pkg-message.in (new)
  1.2       +0 -16     ports/games/openttd/pkg-message (dead)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"