- Add support for threaded Tk by passing PTHREAD_LIBS to configure in -tklibs swith. This allows build with threaded Tk (otherwise configure fails to use Tk). Also depend on threaded Tk by default in case of THREADS support - with non-pthread tk library it will not be stable enough - Add OPTIONS - Enable builds of non-threaded targets - Depend on X in case if X is installed, since configure does this by default. - Rename patchfiles to make portlint happy - Eliminate the number of reinplace patterns (remove duplicates, optimize) - Move manpage list in the separate files - Pass pthread flags to compiler (PTHREAD_CFLAGS/LIBS safety) - Remove some ugly hacks on setting permissions etc (eliminated by setting correct permission in COPY_TREE macros) - Eliminate duplicate entries in PLIST in case of unstalling optimized binaries, also optimize this part - Remove unused PLIST_SUB variable - Miscelanios cleanups in Makefile - Take maintainership The following files was added: - files/man1 - files/manlinks - files/mann - files/patch-camlp4-man_Makefile - files/patch-camlp4_lib_Makefile - files/patch-ocamldoc_Makefile - files/patch-stdlib_Makefile I removed the following files: - files/patch-camlp4-man::Makefile - files/patch-camlp4::lib::Makefile - files/patch-ocamldoc::Makefile - files/patch-stdlib::Makefile
Responsible Changed From-To: freebsd-ports-bugs->itetcu I'll take it.
State Changed From-To: open->feedback Did you test that threading support doesn't break dependent ports ?
On Tue, 1 Aug 2006 09:15:29 GMT Ion-Mihai Tetcu <itetcu@FreeBSD.org> mentioned: > Synopsis: [PATCH] lang/ocaml: add support for threaded tk, lot of fixes, = take maintainership >=20 > State-Changed-From-To: open->feedback > State-Changed-By: itetcu > State-Changed-When: Tue Aug 1 09:15:28 UTC 2006 > State-Changed-Why:=20 > Did you test that threading support doesn't break dependent ports ? >=20 > http://www.freebsd.org/cgi/query-pr.cgi?pr=3D101122 >=20 >=20 Yes. In fact, threading was enabled by default, but if non-threaded version of tk was installed (like my situation) tk probe fails, since threaded cfla= gs was not passed to configure and test program fails to link without ${PTHREAD_LIBS}. Additionaly, there is some problems with labltk linked against non-threaded tk in case of threaded ocaml programs, so I decided to depend on threaded tk in threaded ocaml by default (via DEPENDS_ARGS). --=20 Stanislav Sedov MBSD labs, Inc. <ssedov@mbsd.msk.ru> =F2=CF=D3=D3=C9=D1, =ED=CF=D3=CB=D7=C1 http://mbsd.msk.ru -------------------------------------------------------------------- If the facts don't fit the theory, change the facts. -- A. Einstein -------------------------------------------------------------------- PGP fingerprint: F21E D6CC 5626 9609 6CE2 A385 2BF5 5993 EB26 9581
State Changed From-To: feedback->open response received
State Changed From-To: open->closed Committed, thanks.