Bug 101617 - x11-themes/gtk-qt-engine option to disable libbonoboui support does nothing
Summary: x11-themes/gtk-qt-engine option to disable libbonoboui support does nothing
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-08 00:30 UTC by freebsd
Modified: 2006-08-08 08:12 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description freebsd 2006-08-08 00:30:15 UTC 
Since version 0.7, x11-themes/gtk-qt-engine can optionally use and build-depend on x11-toolkits/libbonoboui. However, the option to enable or disable this does nothing and the dependency is unconditional. The attached patch fixes this.

Fix: 

-LIB_DEPENDS=   kdecore:${PORTSDIR}/x11/kdelibs3 \
-               bonoboui-2:${PORTSDIR}/x11-toolkits/libbonoboui
+LIB_DEPENDS=   kdecore:${PORTSDIR}/x11/kdelibs3

 USE_BZIP2=     yes
 USE_GMAKE=     yes
@@ -30,6 +29,10 @@
 CONFIGURE_ARGS+=--x-libraries=${X11BASE}/lib --x-includes=${X11BASE}/include

 OPTIONS=       BONOBOUI "With libbonoboui (recommended)" on
+
+.if defined(WITH_BONOBOUI)
+LIB_DEPENDS+=  bonoboui-2:${PORTSDIR}/x11-toolkits/libbonoboui
+.endif

 pre-configure:
        @${REINPLACE_CMD} -e "s|/share/themes/|/X11R6/share/themes/|" \--ijJm1RW2Gjq94XfP6rQ7T926kMXg7RpCRxKw6uIHQIDJgYua
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- Makefile.orig       Sat Aug  5 00:44:33 2006
+++ Makefile    Tue Aug  8 01:27:27 2006
@@ -14,8 +14,7 @@
 MAINTAINER=    danny@ricin.com
 COMMENT=       GTK-QT Theme Engine allows GTK2 apps to use QT (KDE) themes
How-To-Repeat: cd /usr/ports/x11-themes/gtk-qt-engine
make WITHOUT_BONOBOUI
-> x11-toolkits/libbonoboui is still checked for and built if not present
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-08-08 00:30:30 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Danny Pansters 2006-08-08 00:54:57 UTC 
Good catch (stupid me). Should be fine to commit. Thanks.
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2006-08-08 00:57:37 UTC 
State Changed
From-To: feedback->open

maintainer approved`
Comment 4 Rong-En Fan freebsd_committer freebsd_triage 2006-08-08 08:12:37 UTC 
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!