- Update to 2.0.3 Generated with FreeBSD Port Tools 0.77
Responsible Changed From-To: freebsd-ports-bugs->adamw I'll take this.
State Changed From-To: open->feedback Set state to feedback for the following: As stated in a previous email to maintainer, I do not believe that OPTIONS are appropriate here. They prevent the system from registering de facto dependencies, and will lead to inevitable broken library links. Also, please double-check about removing the bash dependency. cmus was never before able to build without bash; have you tested it on a bash-less system?
The Build system was converted from bash to sh on 2005-11-13, see: http://onion.dynserv.net/git/?p=cmus.git;a=commit;h=7febfbe6928bfc6671a2eacd5a9588975f47a21b Building cmus without installed bash worked fine for me. I understand your reasons for not using OPTIONS. But I don't think we have to worry about broken dependencies here. When you disable libmodplug in the OPTIONS, the configure script for cmus will be invoked with CONFIG_MODPLUG=n. Regardless if it finds libmodplug or not, it will not build against it, because it has been explicitly disabled. If one would do a configure without CONFIG_MODPLUG=n, then the value would be set to a and cmus would build against it, if it finds the libraries installed. So if you enable an OPTION cmus will be told to build against it and it will be a registered dependency and if you disable it, cmus will not build against nor depend on it. So if this is the only objection against OPTIONS it is solved as far as I can tell. On Wed, Aug 09, 2006 at 06:14:36PM -0400, Adam Weinberger wrote: > The reason that I had stayed away from using OPTIONS is that it cannot > make intelligent decisions based upon what's already in the system. > > For example, say that you have libmodplug installed. You don't change > any of the default OPTIONS, but during the build, cmus finds libmodplug > installed. It will therefore build against it, but there won't be a > dependency registered against it. > > Then, in the future, say you deinstall libmodplug. The ports system > won't give any sort of error, but suddenly cmus will stop working, > complaining that it's missing a required library. > > OPTIONS is good for setting build options, not for choosing what modules > to support. You're the maintainer now, but I strongly suggest that you > resubmit the PR without the OPTIONS changes. -- Mit freundlichem Gruß, With best regards, Simon Olofsson http://olofsson.de
I'm sorry, but I made a little mistake. The Options which are default on should be tested with WITHOUT_*. Here is a new patch which incorporates this: http://olofsson.de/simon/tmp/cmus.patch -- Mit freundlichem Gruß, With best regards, Simon Olofsson http://olofsson.de
I'd missed what the CONFIG_FOO={y,n} stuff did. Looks like you've thought of and solved all the issues I had, and I'm glad that they finally removed the bash necessity! Sorry about the delay; I'll go ahead and commit this. # Adam
State Changed From-To: feedback->closed I've committed this with the olofsson.de patch. Though, FTR, I was under the impression that the OPTIONS system automatically set both WITH_FOO=yes and WITHOUT_FOO=no automatically for each option.