Port biology/treeviewx is hardwired into wxgtk24 eventhough it can compile and run with wxgtk26. Please update the Makefile to detect the wxgtk version, like devel/rapidsvn does.
State Changed From-To: open->feedback Awaiting maintainers feedback
Fernan Aguero wrote: > Dear Reed, > > yes, the port has a hardwired dependency on wxgtk24, but > that's how the ports system works with respect to shared > libraries, we need to specify a library's major version > number: > > http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-depend.html#AEN1983 > > I'll see if I can make it depend on an include (.h) file ... > but that'll have to wait till next week, cause I've got work > to do now. Fernan, From looking at other ports, like devel/rapidsvn, that support either wxgtk24 or wxgtk26, it appears that it is possible for the Makefile to autodetect which one is installed and adjust the dependencies accordingly. If that is not possible for this port, would it be possible to change the dependency to wxgtk26? -- ********************************************************* Reed A. Cartwright, PhD http://scit.us/ Postdoctoral Researcher http://www.dererumnatura.us/ Department of Genetics http://www.pandasthumb.org/ Bioinformatics Research Center North Carolina State University Campus Box 7566 Raleigh, NC 27695-7566 Cuiusvis hominis est errare, nullius nisi insipientis in errore perserverare. --Cicero
Here is a patch, that will make the port accept any version of wx present on the system. It uses the new USE_WX infrastructure. Fernan, do you approve this patch? Index: Makefile =================================================================== RCS file: /home/pcvs/ports/biology/treeviewx/Makefile,v retrieving revision 1.21 diff -a -u -r1.21 Makefile --- Makefile 6 Dec 2005 02:00:55 -0000 1.21 +++ Makefile 7 Oct 2006 16:25:51 -0000 @@ -15,12 +15,10 @@ MAINTAINER= fernan@iib.unsam.edu.ar COMMENT= A phylogenetic tree viewer -LIB_DEPENDS= wx_gtk2-2.4.0:${PORTSDIR}/x11-toolkits/wxgtk24 \ - wx_gtk2_dcsvg-2.4.0:${PORTSDIR}/x11-toolkits/wxgtk24-contrib - +USE_WX= yes +WX_COMPS= wx contrib USE_GMAKE= yes GNU_CONFIGURE= yes -CONFIGURE_ENV= WX_CONFIG="${X11BASE}/bin/wxgtk2-2.4-config" PLIST_FILES= bin/tv -- Pav Lucistnik <pav@oook.cz> <pav@FreeBSD.org> Video games don't affect kids, I mean if Pac Man affected us as kids, we'd all run around in a darkened room munching pills and listening to repetitive music. -- Kristian Wilson, CEO at Nintendo Gaming Corporation Inc
Responsible Changed From-To: freebsd-ports-bugs->pav Get involved
+----[ Pav Lucistnik <pav@FreeBSD.org> (07.Oct.2006 13:44): | | Here is a patch, that will make the port accept any version of wx | present on the system. It uses the new USE_WX infrastructure. | Fernan, do you approve this patch? Approved. Fernan | Index: Makefile | =================================================================== | RCS file: /home/pcvs/ports/biology/treeviewx/Makefile,v | retrieving revision 1.21 | diff -a -u -r1.21 Makefile | --- Makefile 6 Dec 2005 02:00:55 -0000 1.21 | +++ Makefile 7 Oct 2006 16:25:51 -0000 | @@ -15,12 +15,10 @@ | MAINTAINER= fernan@iib.unsam.edu.ar | COMMENT= A phylogenetic tree viewer | | -LIB_DEPENDS= wx_gtk2-2.4.0:${PORTSDIR}/x11-toolkits/wxgtk24 \ | - wx_gtk2_dcsvg-2.4.0:${PORTSDIR}/x11-toolkits/wxgtk24-contrib | - | +USE_WX= yes | +WX_COMPS= wx contrib | USE_GMAKE= yes | GNU_CONFIGURE= yes | -CONFIGURE_ENV= WX_CONFIG="${X11BASE}/bin/wxgtk2-2.4-config" | | PLIST_FILES= bin/tv | | | -- | Pav Lucistnik <pav@oook.cz> | <pav@FreeBSD.org> | | Video games don't affect kids, I mean if Pac Man affected us as kids, we'd all | run around in a darkened room munching pills and listening to repetitive music. | -- Kristian Wilson, CEO at Nintendo Gaming Corporation Inc | | +----]
pav 2006-10-09 07:16:37 UTC FreeBSD ports repository Modified files: biology/treeviewx Makefile Log: - Allow wxWidgets 2.6 alongside 2.4, this port works with both PR: ports/102168 Approved by: Fernan Aguero <fernan@iib.unsam.edu.ar> (maintainer) Revision Changes Path 1.22 +3 -4 ports/biology/treeviewx/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed The port was modified to accept wx 2.6