I've discovered that logjam can be patched a bit to make it even better. Details are here: http://k001.livejournal.com/253678.html. Basically, there're two patches: a small fix of handling backdated entries and keyboard shortcut for image insertion. The other thing is that music detection can be done with BeepMediaPlayer as easily as with XMMS. I've patched Makefile to teach the port to about BMP. I've also done one cosmetic change on COMMENT line in Makefile. Here's approximate commit log message: - Provide clearer and shorter comment - Convert to OPTIONS - Introduce WITH_BEEPMP knob, which tells to use beep-media-player instead of XMMS (must be defined *with* WITH_XMMS) - Detect whether `libxmms.so' or `libbeep.so' if installed - Add two additional patches (backdated entries fix + keyboard shortcut) If you cannot commit it for some reason, I can do it for you. Thanks. Fix: --- protocol/liblivejournal/livejournal/entry.c.orig Thu Aug 17 01:40:10 2006 +++ protocol/liblivejournal/livejournal/entry.c Thu Aug 17 01:45:24 2006 @@ -610,6 +610,12 @@ else if (g_ascii_strcasecmp(key, "time") == 0) { if (entry) lj_ljdate_to_tm(val, &entry->time); } + else if (g_ascii_strcasecmp(key, "backdated") == 0) { + if (entry && val[0]) { + if (g_ascii_strcasecmp(val, "yes") == 0) + entry->backdated = TRUE; + } + } else return FALSE; return TRUE; --- patch-protocol-liblivejournal-livejournal-entry.c ends here --- How-To-Repeat: N/A
Responsible Changed From-To: freebsd-ports-bugs->novel Over to maintainer
Hi, My comments: - I don't agree with your COMMENT change. Livejournal.com is not the only service running livejournal software (e.g. deadjournal.com, lj.rossia.org run it and several others), so the original comment is correct. - I don't want to use OPTIONS for my ports - I don't see any point in BEEPMP knob. If you're using BMP and don't care about extra xmms dependency, you could compile logjam with WITH_XMMS and it _will_ work with BMP. If you want to avoid xmms/gtk12 dependencies, you could compile it without xmms support and use some external command to fetch current music (I use self-written audio/bmp-htmlplaylist, e.g. "bmp-htmlplaylist -c") Additional patches look good, I will add them after some review. Thanks, Roman Bogorodskiy
Alexey Dokuchaev wrote: > In current form, it pulls `multimedia/xmms' as additional dependency if > I want music detection. And I don't want to have xmms being installed, > especially when I have BMP installed as my only music player. The knob > point seems pretty valid to me, since it does not break anything, and > simplifies things for people that have no XMMS bits instated (or do not > want them being installed) on their boxes. Without this knob, we're > essentially forcing our users to come up with some work-around to avoid > dependency, such as writing extra scripts, hacking on port's Makefile > and sources, etc. Not everyone likes writing extra code; I assume most > of us prefer to read through the Makefile (better yet, select stuff via > OPTIONS, but you don't like them for some reason) and simply type "make > install -DFOO" to get software installed with wanted functionality. I > understand that this knob is probably useless to you, but if it does not > break current order of things, I don't see why not to commit it. Because this is hackish to define both -DWITH_XMMS -DWITH_BEEPMP to get BMP support. If you could rework your patch so it was possible to specify only -DWITH_BMP to get BMP, it would be great. PS It's not quite obvious to me why the mainstream developers cannot add BMP support, while the patch exists for about two years now: http://community.livejournal.com/logjam_dev/24832.html OTOH, bmp is legacy now, so people probably should care more about BMPx [1] and audacious. [1] And I wrote a patch for it, but it wasn't accepted as well: http://community.livejournal.com/logjam_dev/31732.html Roman Bogorodskiy
On Sat, Aug 19, 2006 at 12:50:17PM +0000, Roman Bogorodskiy wrote: > Hi, > > My comments: > > - I don't agree with your COMMENT change. Livejournal.com is not > the only service running livejournal software (e.g. deadjournal.com, > lj.rossia.org run it and several others), so the original comment > is correct. OK, fair enough. > - I don't want to use OPTIONS for my ports What's wrong with OPTIONS framework? It seems all rough edges were taken care of pretty long time ago. > - I don't see any point in BEEPMP knob. If you're using BMP and don't > care about extra xmms dependency, you could compile logjam with > WITH_XMMS and it _will_ work with BMP. If you want to avoid xmms/gtk12 > dependencies, you could compile it without xmms support and use some > external command to fetch current music (I use self-written > audio/bmp-htmlplaylist, e.g. "bmp-htmlplaylist -c") In current form, it pulls `multimedia/xmms' as additional dependency if I want music detection. And I don't want to have xmms being installed, especially when I have BMP installed as my only music player. The knob point seems pretty valid to me, since it does not break anything, and simplifies things for people that have no XMMS bits instated (or do not want them being installed) on their boxes. Without this knob, we're essentially forcing our users to come up with some work-around to avoid dependency, such as writing extra scripts, hacking on port's Makefile and sources, etc. Not everyone likes writing extra code; I assume most of us prefer to read through the Makefile (better yet, select stuff via OPTIONS, but you don't like them for some reason) and simply type "make install -DFOO" to get software installed with wanted functionality. I understand that this knob is probably useless to you, but if it does not break current order of things, I don't see why not to commit it. Thanks. ./danfe
On Sat, Aug 19, 2006 at 02:00:17PM +0000, Roman Bogorodskiy wrote: > Alexey Dokuchaev wrote: > > > In current form, it pulls `multimedia/xmms' as additional dependency if > > I want music detection. And I don't want to have xmms being installed, > > especially when I have BMP installed as my only music player. The knob > > point seems pretty valid to me, since it does not break anything, and > > simplifies things for people that have no XMMS bits instated (or do not > > want them being installed) on their boxes. Without this knob, we're > > essentially forcing our users to come up with some work-around to avoid > > dependency, such as writing extra scripts, hacking on port's Makefile > > and sources, etc. Not everyone likes writing extra code; I assume most > > of us prefer to read through the Makefile (better yet, select stuff via > > OPTIONS, but you don't like them for some reason) and simply type "make > > install -DFOO" to get software installed with wanted functionality. I > > understand that this knob is probably useless to you, but if it does not > > break current order of things, I don't see why not to commit it. > > Because this is hackish to define both -DWITH_XMMS -DWITH_BEEPMP to get > BMP support. If you could rework your patch so it was possible to > specify only -DWITH_BMP to get BMP, it would be great. OK, I will work on it. ./danfe > > PS It's not quite obvious to me why the mainstream developers cannot add > BMP support, while the patch exists for about two years now: > > http://community.livejournal.com/logjam_dev/24832.html > > OTOH, bmp is legacy now, so people probably should care more about BMPx > [1] and audacious. > > [1] And I wrote a patch for it, but it wasn't accepted as well: > http://community.livejournal.com/logjam_dev/31732.html > > Roman Bogorodskiy
State Changed From-To: open->feedback Asked to rework the patch.
State Changed From-To: feedback->closed No progress since the last year.