Bug 102514 - [patch] bsd.port.mk: "set $var" ==> "set -- $var"
Summary: [patch] bsd.port.mk: "set $var" ==> "set -- $var"
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-25 21:00 UTC by Andrew Pantyukhin
Modified: 2006-09-20 05:10 UTC (History)
0 users

See Also:


Attachments
bpm.set.diff (1.68 KB, patch)
2006-08-25 21:00 UTC, Andrew Pantyukhin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Pantyukhin freebsd_committer freebsd_triage 2006-08-25 21:00:36 UTC
sh(1) recommends using "set -- <new args>" instead of just,
"set <new args>", but of course marcus, kris, and clement
chose to avoid wasting 3 bytes in each case ;-)

Fix: http://people.freebsd.org/~sat/diffs/bpm.set.diff
How-To-Repeat: Try defining empty MLINKS - and look what happens at install
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-08-25 21:00:46 UTC
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

bsd.port.mk is port manager territory
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2006-09-15 08:43:53 UTC
State Changed
From-To: open->analyzed

kris is running a test build on the cluster with this one.
Comment 3 dfilter service freebsd_committer freebsd_triage 2006-09-20 05:02:16 UTC
kris        2006-09-20 04:02:09 UTC

  FreeBSD ports repository

  Modified files:
    Mk                   bsd.port.mk 
  Log:
  * Add missing '|| true' to silence an @unexec rmdir [1]
  
  * Repair CONFLICTS, which was broken by previous DESTDIR changes [2]
  
  * Use "set --" instead of "set" for better robustness [3]
  
  * Avoid :L modifier in ${USE_LDCONFIG} which broke e.g. /usr/X11R6
    ports [4]
  
  * Correct a comment typo [4]
  
  * Force passive FTP mode by default (this is already the default with
    the standard login class, so this is a NOP for most users) [5].
  
  PR:             ports/101809 [1], ports/102300 [2], ports/102514 [3],
                  ports/102750 [4], ports/96088 [5]
  Submitted by:   bsam [1], Matthias Andree <matthias.andree@gmx.de> [2],
                  infofarmer [3], flz [4],
                  Darren Pilgrim <darren.pilgrim@bitfreak.org> [5]
  
  Revision  Changes    Path
  1.542     +14 -10    ports/Mk/bsd.port.mk
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Kris Kennaway freebsd_committer freebsd_triage 2006-09-20 05:04:46 UTC
State Changed
From-To: open->closed

Committed, thanks!
Comment 5 Kris Kennaway freebsd_committer freebsd_triage 2006-09-20 05:04:46 UTC
State Changed
From-To: analyzed->closed

Committed, thanks!
Comment 6 Kris Kennaway freebsd_committer freebsd_triage 2006-09-20 05:04:46 UTC
State Changed
From-To: analyzed->closed

Committed, thanks!