Bug 102971 - [Maintiner-update]: sysutils/flexbackup PREFIX fix and OPTIONization
Summary: [Maintiner-update]: sysutils/flexbackup PREFIX fix and OPTIONization
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ion-Mihai "IOnut" Tetcu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-07 09:50 UTC by Marcus von Appen
Modified: 2006-10-10 13:00 UTC (History)
0 users

See Also:


Attachments
file.diff (2.15 KB, patch)
2006-09-07 09:50 UTC, Marcus von Appen
no flags Details | Diff
flex_rev.diff (2.15 KB, patch)
2006-09-07 18:12 UTC, Marcus von Appen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marcus von Appen freebsd_committer freebsd_triage 2006-09-07 09:50:12 UTC
        The following patch fixes the ugly PREFIX misbehaviour of
        flexbackup.
        By default it expects its configuration file, flexbackup.conf,
        in /etc/ as longas WITH_PREFIX_CONF is not explicitly set.
        
        I changed it to use PREFIX as default now, so flexbackup expects
        flexbackup.conf being in PREFIX/etc

        Before:
        /etc/flexbackup.conf        for PREFIX=whatever, WITH_PREFIX_CONF unset
        Now:
        PREFIX/etc/flexbackup.conf  for PREFIX=whatever

        The changed behaviour should be noted in UPDATING, I guess.

        The port make use of OPTIONS and got a revision bump for the
        PREFIX change.

        I'll take over maintainership for this.
Comment 1 Marcus von Appen freebsd_committer freebsd_triage 2006-09-07 18:12:41 UTC
Unfortunately the OPTIONS knobs won't work, because I placed them behind
<bsd.port.pre.mk>.

A revised patch which fixes this is attached.

Regards
Marcus
Comment 2 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2006-09-08 21:03:26 UTC
Responsible Changed
From-To: freebsd-ports-bugs->itetcu

I'll take it.
Comment 3 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2006-09-08 21:16:42 UTC
State Changed
From-To: open->feedback

There's a problem with the pre-everything message, as the only reference 
to gtar is for OSVESION 600022: Removed gtar from base system.
Comment 4 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2006-09-09 11:43:46 UTC
State Changed
From-To: feedback->open

new patch received
Comment 5 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2006-09-09 11:47:53 UTC
State Changed
From-To: open->feedback

So, only the makefile ischanged now ?  This port requires gtar, right ? 
then, is it OK to depend on gtar only for OSVERSION>=600022 ?
Comment 6 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2006-09-09 13:04:43 UTC
State Changed
From-To: feedback->open

this port needs gtar unconditionally
Comment 7 Marcus von Appen freebsd_committer freebsd_triage 2006-10-05 21:44:03 UTC
Any news here?

Regards
Marcus
Comment 8 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2006-10-05 22:27:09 UTC
On Thu, 5 Oct 2006 20:50:22 GMT
Marcus von Appen <mva@sysfault.org> wrote:

>  Any news here?


Not yet, but I'll commit it before the freeze

-- 
IOnut - Un^d^dregistered ;) FreeBSD "user"
  "Intellectual Property" is   nowhere near as valuable   as "Intellect"

BOFH excuse #211:
Lightning strikes

Comment 9 dfilter service freebsd_committer freebsd_triage 2006-10-10 09:23:47 UTC
itetcu      2006-10-10 08:23:41 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/flexbackup  Makefile 
  Added files:
    sysutils/flexbackup/files patch-flexbackup.conf 
  Log:
  - patch sources to respect PREFIX instead of using custom hacks:
  Before:
  /etc/flexbackup.conf for PREFIX=whatever, WITH_PREFIX_CONF unset
  Now:
  PREFIX/etc/flexbackup.conf for PREFIX=whatever
  - depend on right (g)tar depending on FreeBSD version
  - pass maintainership to submitter
  
  PR:             ports/102971
  Submitted by:   Marcus von Appen
  
  Revision  Changes    Path
  1.22      +32 -33    ports/sysutils/flexbackup/Makefile
  1.1       +11 -0     ports/sysutils/flexbackup/files/patch-flexbackup.conf (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 10 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2006-10-10 09:23:52 UTC
State Changed
From-To: open->closed

Commited, Thanks!
Comment 11 dfilter service freebsd_committer freebsd_triage 2006-10-10 12:50:46 UTC
itetcu      2006-10-10 11:50:40 UTC

  FreeBSD ports repository

  Modified files:
    .                    UPDATING 
  Log:
  Mention sysutils/flexbackup now expects the .conf file in the standard place.
  
  PR:             ports/102971
  Submitted by:   Marcus von Appen
  
  Revision  Changes    Path
  1.408     +11 -1     ports/UPDATING
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"