Bug 103355 - [patch] Broken FlickrExport plugin from graphics/kipi-plugins
Summary: [patch] Broken FlickrExport plugin from graphics/kipi-plugins
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Markus Brueffer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-18 15:30 UTC by Artem Naluzhny
Modified: 2006-10-24 20:20 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Artem Naluzhny 2006-09-18 15:30:16 UTC
FlickrExport plugin from kipi-plugins-0.1.0.r1_4,1 (graphics/kipi-plugins) does not work: "missing signature" message on console.

This is known bug caused by Flickr API changes - http://bugs.kde.org/show_bug.cgi?id=132659

Suggested patch resolves the issue.

Fix: 

--- kipi-plugins/flickrexport/flickrtalker.cpp.orig
+++ kipi-plugins/flickrexport/flickrtalker.cpp
@@ -277,7 +277,7 @@
 
 		QString isfriend=(info.is_friend==1)?"1":"0";
 		form.addPair("is_friend",isfriend);
-		headers.append("api_key="+ isfriend);
+		headers.append("is_friend="+ isfriend);
 
 		QString tags=info.tags.join(" ");
 		if(tags.length()>0){	
@@ -297,6 +297,7 @@
 		}
 
 		QString md5=getApiSig(m_secret,headers);
+		form.addPair("api_sig", md5);
 		headers.append("api_sig="+ md5);
 		QString queryStr=headers.join("&");
 		QString postUrl=url+queryStr;
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-09-18 15:30:44 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Markus Brueffer freebsd_committer freebsd_triage 2006-10-24 14:01:54 UTC
Responsible Changed
From-To: freebsd-ports-bugs->markus

I'll handle this one.
Comment 3 Markus Brueffer freebsd_committer freebsd_triage 2006-10-24 20:15:11 UTC
State Changed
From-To: feedback->closed

Committed, thanks! 

The maintainer approved the patch via private mail.
Comment 4 dfilter service freebsd_committer freebsd_triage 2006-10-24 20:16:24 UTC
markus      2006-10-24 19:14:51 UTC

  FreeBSD ports repository

  Modified files:
    graphics/kipi-plugins Makefile pkg-plist 
  Added files:
    graphics/kipi-plugins/files 
                                patch-kipi-plugins-flickrexport-flickrtalker.cpp 
  Log:
  - Fix pkg-plist and unbreak
  - Fix Flickr export plugin [1]
  - Bump PORTREVISION
  
  PR:             ports/103355 [1]
  Submitted by:   Artem Naluzhny <tut@nhamon.com.ua> [1]
  Approved by:    portmgr (marcus), maintainer
  
  Revision  Changes    Path
  1.20      +1 -3      ports/graphics/kipi-plugins/Makefile
  1.1       +19 -0     ports/graphics/kipi-plugins/files/patch-kipi-plugins-flickrexport-flickrtalker.cpp (new)
  1.7       +17 -0     ports/graphics/kipi-plugins/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"