Bug 103358 - Broken Privoxy rc.d script
Summary: Broken Privoxy rc.d script
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-18 16:40 UTC by Richard Bejtlich
Modified: 2006-10-07 17:50 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Bejtlich 2006-09-18 16:40:22 UTC
/usr/local/etc/rc.d/privoxy contains the following:

su -m privoxy -c "${command} ${privoxy_flags} ${configfile} --pidfile ${pidfile}" \

This will not work.

Running it from the command line shows why:

orr:/root# su -m privoxy -c /usr/local/sbin/privoxy /usr/local/etc/privoxy/config --pidfile /var/run/privoxy/privoxy.pid
Sep 18 11:33:26 Privoxy(134729728) Fatal error: can't check configuration file '/root/config':  No such file or directory
Sep 18 11:33:26 Privoxy(134729728) Fatal error: can't check configuration file '/root/config':  No such file or directory

Fix: Remove su -m:

orr:/root# privoxy -c /usr/local/sbin/privoxy /usr/local/etc/privoxy/config --pidfile /var/run/privoxy/privoxy.pid
Sep 18 11:33:40 Privoxy(134729728) Info: loading configuration file '/usr/local/etc/privoxy/config':
orr:/root# sockstat -4
USER     COMMAND    PID   FD PROTO  LOCAL ADDRESS         FOREIGN ADDRESS      
root     privoxy    39480 3  tcp4   127.0.0.1:8118        *:*
richard  ssh        691   3  tcp4   192.168.2.5:49499     172.16.3.2:22
root     sendmail   468   4  tcp4   127.0.0.1:25          *:*
root     sshd       462   4  tcp4   *:22                  *:*
root     syslogd    320   7  udp4   *:514                 *:*

orr:/usr/local/etc/rc.d# diff -u privoxy.orig privoxy


Thank you!--4MLafZ71veOYXrC7OTCv8z7nFknJ8Y4E58x8EzR2NKrgow2b
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- privoxy.orig        Mon Sep 18 11:37:52 2006
+++ privoxy     Mon Sep 18 11:38:01 2006
@@ -30,7 +30,7 @@
                echo "${name} is already running"
        else
                echo "Starting ${name}."
-               su -m privoxy -c "${command} ${privoxy_flags} ${configfile} --pidfile ${pidfile}" \
+               privoxy -c "${command} ${privoxy_flags} ${configfile} --pidfile ${pidfile}" \
                1>/dev/null 2>&1
        fi
 }
How-To-Repeat: Use the following Privoxy:

orr:/root# pkg_info | grep priv
privoxy-3.0.3_4     Privoxy is a web proxy with advanced filtering capabilities
Comment 1 Richard Bejtlich 2006-09-18 17:50:43 UTC
Sorry about that -- I provided a bad fix.

I should have put "/usr/local/sbin/privoxy
/usr/local/etc/privoxy/config --pidfile /var/run/privoxy/privoxy.pid"
in quotes when I ran my command line test, and I didn't notice that my
"fix" ended up running Privoxy as root. Argh.

Once I created directories /var/log/privoxy and /var/run/privoxy/
owned by privoxy:privoxy, I had no trouble with the startup script.

Thank you,

Richard
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2006-09-18 22:24:49 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 3 Pav Lucistnik freebsd_committer freebsd_triage 2006-10-07 17:47:22 UTC
State Changed
From-To: feedback->closed

Maintainer's patch committed.
Comment 4 dfilter service freebsd_committer freebsd_triage 2006-10-07 17:47:24 UTC
pav         2006-10-07 16:47:15 UTC

  FreeBSD ports repository

  Modified files:
    www/privoxy          Makefile pkg-plist 
    www/privoxy/files    pkg-message.in 
  Added files:
    www/privoxy/files    privoxy.in 
  Removed files:
    www/privoxy/files    patch-configure.in privoxy.sh.in 
  Log:
  - Remove old patch that disabled libc_r functions, not needed anymore
  - Update maintainer's address
  - Improve rc script
  - Install standard.action
  - Don't send console messages to /dev/null
  
  PR:             ports/103358
  Submitted by:   Fabian Keil <freebsd-listen@fabiankeil.de> (maintainer)
  
  Revision  Changes    Path
  1.17      +4 -5      ports/www/privoxy/Makefile
  1.2       +0 -141    ports/www/privoxy/files/patch-configure.in (dead)
  1.2       +19 -4     ports/www/privoxy/files/pkg-message.in
  1.1       +42 -0     ports/www/privoxy/files/privoxy.in (new)
  1.4       +0 -50     ports/www/privoxy/files/privoxy.sh.in (dead)
  1.5       +1 -0      ports/www/privoxy/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"