Bug 103966 - devel/p5-IO-Multiplex includes Time::HiRes regardless of perl version
Summary: devel/p5-IO-Multiplex includes Time::HiRes regardless of perl version
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Anton Berezin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-04 07:30 UTC by Jeremy Chadwick
Modified: 2006-11-06 01:30 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Chadwick 2006-10-04 07:30:17 UTC
	p5-IO-Multiplex blindly includes a dependency on devel/p5-Time-HiRes
	regardless of which version of perl is installed on the system.

	Starting with perl 5.7.2, Time::HiRes is included with perl -- however,
	there are known issues with the base-included Time::HiRes module in
	perl 5.8.4 and below.  A simple .if wrapper which checks PERL_LEVEL
	should solve this.

	If you need something to compare with (for sake of integrity), look at
	devel/p5-Spoon, net/p5-Net-Amazon, net/p5-POE-Component-Client-Traceroute,
	or www/p5-Apache-ASP.

	NOTE: True, perl 5.8.8 includes Time::HiRes version 1.86 while the port
	is for 1.91, but this really should not make a difference on UNIX.  The
	changes beween 1.86 and 1.91 are mainly for Cygwin, minus one fixup in
	1.91 for SuSE Linux, which obviously doesn't apply here.  Here's the
	official Time::HiRes ChangeLog if you have concerns committing this:
	http://search.cpan.org/src/JHI/Time-HiRes-1.91/Changes

Fix: Apply the below patch.




+.if ${PERL_LEVEL} < 500805
 BUILD_DEPENDS= ${SITE_PERL}/${PERL_ARCH}/Time/HiRes.pm:${PORTSDIR}/devel/p5-Time-HiRes
 RUN_DEPENDS=   ${BUILD_DEPENDS}
+.endif

 PERL_CONFIGURE=        yes--0XOliG9MWGRER3ojfnZ4nOfsiO0wR65KicNxkgJdY3gUNj4h
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- Makefile.orig       Sun Feb 15 06:51:55 2004
+++ Makefile    Tue Oct  3 23:11:02 2006
@@ -15,8 +15,10 @@
 MAINTAINER=    tobez@FreeBSD.org
 COMMENT=       IO::Multiplex - Manage IO on many file handles
How-To-Repeat: 	n/a
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-10-04 07:30:34 UTC
Responsible Changed
From-To: freebsd-ports-bugs->tobez

Over to maintainer
Comment 2 Florent Thoumie freebsd_committer freebsd_triage 2006-11-06 01:25:18 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 3 dfilter service freebsd_committer freebsd_triage 2006-11-06 01:25:56 UTC
flz         2006-11-06 01:25:47 UTC

  FreeBSD ports repository

  Modified files:
    devel/p5-IO-Multiplex Makefile 
  Log:
  - Don't depend on Time::HiRes for perl >= 5.8, since it's included in
  default distribution.
  
  PR:             ports/103966
  Submitted by:   Jeremy Chadwick <freebsd@jdc.parodius.com>
  Approved by:    maintainer timeout (1 month)
  
  Revision  Changes    Path
  1.7       +2 -0      ports/devel/p5-IO-Multiplex/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"