Bug 104255 - x11/wdm Unable to change window manager after the first selection/login.
Summary: x11/wdm Unable to change window manager after the first selection/login.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Soeren Straarup
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-10 12:20 UTC by martinko
Modified: 2008-12-28 18:20 UTC (History)
0 users

See Also:


Attachments
file.diff (11.07 KB, patch)
2006-10-10 12:20 UTC, martinko
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description martinko 2006-10-10 12:20:19 UTC
A bug in Xsession makes it impossible (under certain circumstances) for a user to change window manager for new session.

Other amendments and enhancements are part of this delivery, too.  For details please see description/discussion below.

---

On Sat, Oct 07, 2006 at 08:35:59PM +0200, "mato" wrote:
> > Soeren,
> > 
> > I haven't received any response from you to my latest email, yet.
> > I guess you've either been busy or my mail server failed me again.

I'm sorry i've been busy lately, but your not forgotten

> > 
> > Either way, I've made some changes to the files which I'm sending to you.

Hi can i get you to send a pr with these files? Since that is the right
way to do it.

> > Here's what I've done:
> > 
> > In /usr/X11R6/lib/X11/wdm/Xsession:
> > 
> > - I changed bash to sh(1).
> > - I quoted some variables.
> > - I changed ">" to ">|" in order to force overwriting of .wm_style.
> > - I amended sourcing of X11 resources and start-up code. [Based on
> > original X11 code.]
> > 
> > In /usr/X11R6/lib/X11/wdm/Xclients:
> > 
> > - I changed some bash constructs/syntax to sh(1)
> > - I double checked Xrootenv.0 stuff and commented it out.
> > - I quoted some variables.
> > - I got rid off the original WINMGR_* stuff (which was not used at all)
> > and transformed it to something useful.
> > - I amended sourcing of X11 resources. [This we do actually twice now
> > (!) but I'm not sure where it should be left/done. Well, better twice
> > than never.]
> > - I expanded case selectors.
> > - I refactored some of the code. [Except for Afterstep part which I
> > wasn't sure about.]
> > 
> > I believe the changes made improves the quality of the code as well as
> > user experience and I hope you would agree.  Should anything be not
> > clear, please let me know.
> > 
> > With regards,
> > 
> > Martin
> > 
> > :mato: wrote:

Fix: Output redirection must force file overwriting in Xsession.
And there are actually a couple of other places where this needs to be fixed in both Xsession and Xclients.

Please apply attached patches.

NOTE: I am sorry but I was not able to figure out how to substitute the following hardcoded paths with autoconf @*@ stuff:

Xclients.in:sysresources="/usr/X11R6/lib/X11/xinit/.Xresources"
Xclients.in:sysmodmap="/usr/X11R6/lib/X11/xinit/.Xmodmap"
Xsession.in:sysresources="/usr/X11R6/lib/X11/xinit/.Xresources"


Patch attached with submission follows:
How-To-Repeat: Add "set -o noclobber" into your .bashrc file and you won't be able to change window manager after initial selection on login.

For other "issues" pls read description above. Thanks.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-10-10 12:27:30 UTC
Responsible Changed
From-To: freebsd-ports-bugs->freebsd-x11

Over to maintainer
Comment 2 lesi freebsd_committer freebsd_triage 2006-10-10 17:28:38 UTC
Responsible Changed
From-To: freebsd-x11->xride

Bounce to real maintainer and note the port in question in Synopsis.
Comment 3 martinko 2008-12-24 15:33:56 UTC
Hallo,

This PR for x11/wdm has not been acted on for more than 2 years despite many 
details and patches included.  I use the port daily and after each 
(re)installation I have to patch it manually.  :-/
Could someone please look at and commit it sooner than later ?

Many thanks!

Martin
Comment 4 dfilter service freebsd_committer freebsd_triage 2008-12-28 18:17:18 UTC
xride       2008-12-28 18:17:07 UTC

  FreeBSD ports repository

  Modified files:
    x11/wdm              Makefile 
  Added files:
    x11/wdm/files        patch-change_wm 
  Log:
  Unable to change window manager after the first selection/login.
  
  PR:             104255
  Submitted by:   martinko  <gamato@users.sf.net>
  
  Revision  Changes    Path
  1.81      +7 -1      ports/x11/wdm/Makefile
  1.1       +452 -0    ports/x11/wdm/files/patch-change_wm (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Soeren Straarup freebsd_committer freebsd_triage 2008-12-28 18:18:05 UTC
State Changed
From-To: open->closed

Committed thanks