Bug 104340 - [PATCH] make multimedia/mplayer work with -DWITHOUT_X11
Summary: [PATCH] make multimedia/mplayer work with -DWITHOUT_X11
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ion-Mihai "IOnut" Tetcu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-12 13:50 UTC by Jeremie Le Hen
Modified: 2006-10-15 13:10 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (482 bytes, patch)
2006-10-12 13:50 UTC, Jeremie Le Hen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremie Le Hen 2006-10-12 13:50:18 UTC
	multimedia/mplayer port breaks when compiled with -DWITHOUT_X11.
	It breaks with:
	% font_load_ft.c:30:35: fontconfig/fontconfig.h: No such file or directory
	and number of error messages that undoubtfully result from the former.

	The problem is that mplayer is still compiled with fontconfig support,
	which stands in ${X11BASE}, but gcc is not instructed to look in
	${X11BASE}/include in the WITHOUT_X11 case.

Fix: I tried multiple ways to fix this.  Appending ":${X11BASE}/include"
	to the "--with-extraincdir" directive in CONFIGURE_ARGS doesn't
	anything to the problem (though I don't understand why).
	Nonetheless, adding CFLAGS+=-I${X11BASE}/include in the
	WITHOUT_X11 case works.

	However I am not sure why fontconfig is required when building
	without X11 support ; IMO this is harmless to disable fontconfig
	in this case, and that's what my patch does.

	If there are good reasons to keep compiling with fontconfig
	support, then I suggest either moving fontconfig to ${LOCALBASE}
	although it would conflict with its category (x11-fonts), or
	use the CFLAGS trick described above.

	At any rate, here is patch that disable fontconfig in the
	WITHOUT_X11 case:
How-To-Repeat: 	Just try to build multimedia/mplayer with -DWITHOUT_X11.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-10-12 13:50:33 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Thomas E. Zander 2006-10-12 15:30:47 UTC
Approved. Please commit it.

Thanks,
Riggs

-- 
- Now the world has gone to bed  | Now I lay me down to sleep        -
-- Darkness won't engulf my head | Try to count electric sheep      --
--- I can see by infra-red       | Sweet dream wishes you can keep ---
---- How I hate the night        | How I hate the night           ----
Comment 3 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2006-10-15 12:17:43 UTC
Responsible Changed
From-To: freebsd-ports-bugs->itetcu

I'll take it.
Comment 4 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2006-10-15 12:58:53 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 5 dfilter service freebsd_committer freebsd_triage 2006-10-15 13:01:25 UTC
itetcu      2006-10-15 12:01:18 UTC

  FreeBSD ports repository

  Modified files:
    multimedia/mplayer   Makefile 
  Log:
  Unbrake build in -DWITHOUT_X11 case by --disable-fontconfig.
  
  PR:             ports/104340
  Submitted by:   Jeremie Le Hen <jeremie@le-hen.org>
  Approved by:    maintainer (Thomas E. Zander)
  Approved by:    portmgr (clement)
  
  Revision  Changes    Path
  1.145     +2 -1      ports/multimedia/mplayer/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"