Bug 104465 - port www/apache13-modperl: stale RcNG script
Summary: port www/apache13-modperl: stale RcNG script
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-apache (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-16 14:40 UTC by Andrey Alakozov
Modified: 2007-03-14 20:30 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Alakozov 2006-10-16 14:40:18 UTC
Port www/apache13-mod_perl has RcNG script 'files/apache.sh' with following string

apache_flags=""

But then 'apache_flags' is set in /etc/rc.conf nothig happens, no flags are set  for httpd start.  

Similar port, www/apache13 (note: without mod_perl), has similar file 'apache.sh', but flags are set where by the other way:

apache_flags=${apache_flags-""}

With this line flags are set OK.

Fix: 

Sync apache.sh with similar script in port www/apache.
How-To-Repeat: 1. Install port www/apache13-mod_perl

2. Add add to /etc/rc.conf

apache_enable="YES"
apache_flags="-v"

3. Reboot

4. Apache will start instead of showing version.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-10-16 22:17:05 UTC
Responsible Changed
From-To: freebsd-ports-bugs->apache

Over to maintainer
Comment 2 Volker 2007-03-01 18:21:59 UTC
here's a patch to solve that PR:

--- apache.sh.orig      Thu Mar  1 19:02:35 2007
+++ apache.sh   Thu Mar  1 19:04:58 2007
@@ -14,8 +14,8 @@
 # DO NOT CHANGE THESE DEFAULT VALUES HERE
 #
 apache_enable="${apache_enable-NO}"
-apache_flags=""
-apache_pidfile="/var/run/httpd.pid"
+apache_flags="${apache_flags=''}"
+apache_pidfile="${apache_pidfile='/var/run/httpd.pid'}"

 . %%RC_SUBR%%
Comment 3 Pav Lucistnik freebsd_committer freebsd_triage 2007-03-14 19:55:57 UTC
State Changed
From-To: open->closed

Fixed, thanks!
Comment 4 dfilter service freebsd_committer freebsd_triage 2007-03-14 20:21:37 UTC
pav         2007-03-14 20:21:31 UTC

  FreeBSD ports repository

  Modified files:
    www/apache13-modperl Makefile pkg-plist 
  Added files:
    www/apache13-modperl/files apache.in 
  Removed files:
    www/apache13-modperl/files apache.sh 
  Log:
  - Fix rc script to have overridable apache_flags and apache_pidfile
  
  PR:             ports/104465
  Reported by:    Andrey Alakozov <aa29@mail.ru>
  Submitted by:   Volker <volker@vwsoft.com>
  Approved by:    maintainer timeout (apache; 5 months)
  
  - While here, modernize USE_RC_SUBR usage
  
  Revision  Changes    Path
  1.18      +2 -8      ports/www/apache13-modperl/Makefile
  1.1       +32 -0     ports/www/apache13-modperl/files/apache.in (new)
  1.4       +0 -32     ports/www/apache13-modperl/files/apache.sh (dead)
  1.7       +0 -1      ports/www/apache13-modperl/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"