Bug 105154 - shells/tcshrc script sets wrong values
Summary: shells/tcshrc script sets wrong values
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-04 20:40 UTC by Ingo Petersen
Modified: 2006-12-26 13:40 UTC (History)
0 users

See Also:


Attachments
file.txt (13.81 KB, text/plain)
2006-11-04 20:40 UTC, Ingo Petersen
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ingo Petersen freebsd_committer freebsd_triage 2006-11-04 20:40:02 UTC
In the tcshrc.complete script from pakage "tcshrc" the MANPATH ist set wrong so that not all manpages are avaiable.

In the tcshrc.alias there are aliases to ls --color which does not work
with freebsds ls.

In the tcshrc_config install scrip are aliases to cp --verbose and cp -u
which also does not exit in Freebsds cp.

Fix: here are the fixes i made for me:
(the diffs are applied as a uuencoded tar file)

--- originale/tcshrc_config	Wed Mar 15 10:44:29 2006
+++ angepasste/tcshrc_config	Sun Oct 29 18:00:27 2006
@@ -36,7 +36,7 @@
 	SYSTEM=y
 	;;
     -v|--verbose)
-	VERBOSE=--verbose
+	VERBOSE=-v
 	;;
     -*)
 	usage
@@ -62,7 +62,18 @@
 	/bin/cp -f ${VERBOSE} ${SOURCE}/tcshrc.set 	${HOME}/.tcshrc.set
 	/bin/cp -f ${VERBOSE} ${SOURCE}/tcshrc.alias 	${HOME}/.tcshrc.alias
 	/bin/cp -f ${VERBOSE} ${SOURCE}/tcshrc.hosts 	${HOME}/.tcshrc.hosts
-	/bin/cp -u ${VERBOSE} ${SOURCE}/tcshrc.local 	${HOME}/.tcshrc.local
+	
+	if [ "`uname`" != "Linux" ] ; then
+	    if [ -e "${HOME}/.tcshrc.local" ] ; then
+		/bin/cp -f ${VERBOSE} ${HOME}/.tcshrc.local ${HOME}/.tcshrc.local.old
+		/bin/cp -f ${VERBOSE} ${SOURCE}/tcshrc.local 	${HOME}/.tcshrc.local		
+	
+	    else /bin/cp -f ${VERBOSE} ${SOURCE}/tcshrc.local 	${HOME}/.tcshrc.local
+		fi
+	    else /bin/cp -u ${VERBOSE} ${SOURCE}/tcshrc.local 	${HOME}/.tcshrc.local
+		
+	fi
+
 	echo " done." >&2
 	exit 0
 fi



---------------------------------------------------------------------------
--- originale/tcshrc.complete	Wed Mar 15 10:44:28 2006
+++ angepasste/tcshrc.complete	Sat Nov  4 20:39:58 2006
@@ -714,13 +714,12 @@
     endif
     unset _maildir
 
-    if (! $?MANPATH) then
-	if (-r /usr/share/man) then
-	    setenv MANPATH /usr/share/man:
-	else
-	    setenv MANPATH /usr/man:
-	endif
-    endif
+
+# changed from original file to allow to use all manpathes found
+# by the manpath utility, not only one path
+
+unsetenv MANPATH
+setenv MANPATH `manpath`
 
 	if ($?traditional_complete) then
     # use of $MANPATH from Dan Nicolaescu <dann@ics.uci.edu>

----------------------------------------------------------------------------

--- originale/tcshrc.alias	Wed Mar 15 10:44:28 2006
+++ angepasste/tcshrc.alias	Sun Oct 29 19:03:37 2006
@@ -21,7 +21,7 @@
 
 ## Standard aliases - convenience
 # Color syntax
-alias ls 	'ls --color'
+alias ls 	'ls -G'
 # Typicaly "more" does not allow you to use the arrow keys/etc for navigation.
 # Thus, we try to use "less", if it exists. Some distros do not put the
 # fileutils package and it is annoying if the alias exists without the app.
@@ -73,7 +73,7 @@
 alias maek  'make'
 alias alais 'alias'
 alias csl   'clear'
-alias sl    'ls --color'
+alias sl    'ls -G'
 
 ## Aliases specific to TCSH
 # What is the help command? Type "ls" and hit F1. Will show a help line.
@@ -127,3 +127,9 @@
 #alias clean 'rm -f  *~'
 # This is useful to translators checking .po files.
 alias msgcheck 'msgfmt -o /dev/null --statistics --strict --verbose'
+
+#Install  `most` from he ports or package for coloured manpages
+
+if ( -e `where most`) then
+	alias man 	'man -P most'
+endif
\ No newline at end of file




Patch attached with submission follows:
How-To-Repeat: Install tcshrc from packages or ports.
execute tcshrc_config with optins -v and -u.

after installed (tcshrc_config -s works fine)
type "ls" on command prompt.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-11-04 23:49:06 UTC
Responsible Changed
From-To: freebsd-ports-bugs->seanc

Over to maintainer
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2006-12-13 16:40:28 UTC
Responsible Changed
From-To: seanc->freebsd-ports-bugs

Maintainer was reset.
Comment 3 Emanuel Haupt freebsd_committer freebsd_triage 2006-12-26 13:01:22 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ehaupt

I will take care of it.
Comment 4 dfilter service freebsd_committer freebsd_triage 2006-12-26 13:29:33 UTC
ehaupt      2006-12-26 13:29:26 UTC

  FreeBSD ports repository

  Modified files:
    shells/tcshrc        Makefile 
  Added files:
    shells/tcshrc/files  patch-src__tcshrc.alias 
                         patch-src__tcshrc.complete 
                         patch-tcshrc_config 
  Log:
  Apply FreeBSD specific changes:
  
    * 'ls --color' -> 'ls -G'
    * adjusted manpath
  
  NOTE: Submitter is encouraged to submit the changes to the author.
  
  PR:             105154 (based on)
  Submitted by:   ingo.petersen.webfreenet.de
  
  Revision  Changes    Path
  1.6       +8 -4      ports/shells/tcshrc/Makefile
  1.1       +31 -0     ports/shells/tcshrc/files/patch-src__tcshrc.alias (new)
  1.1       +22 -0     ports/shells/tcshrc/files/patch-src__tcshrc.complete (new)
  1.1       +31 -0     ports/shells/tcshrc/files/patch-tcshrc_config (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Emanuel Haupt freebsd_committer freebsd_triage 2006-12-26 13:29:47 UTC
State Changed
From-To: open->closed

Committed, with modifications, thanks! Please make sure the patches go into the 
upstream version.