Bug 105218 - www/plugger installs to X11BASE, preventing www/firefox from seeing it
Summary: www/plugger installs to X11BASE, preventing www/firefox from seeing it
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rong-En Fan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-06 19:10 UTC by Henrik Brix Andersen
Modified: 2006-11-21 07:10 UTC (History)
1 user (show)

See Also:


Attachments
plugger.diff (285 bytes, patch)
2006-11-06 19:10 UTC, Henrik Brix Andersen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Henrik Brix Andersen 2006-11-06 19:10:14 UTC
Recent versions of www/firefox was moved from X11BASE to LOCALBASE,
but www/plugger still installs to X11BASE, thus preventing www/firefox
from detecting the plug-in.

Fix: The patch below moves www/plugger from X11BASE to LOCALBASE.
	
How-To-Repeat: Install www/firefox and www/plugger, lauch firefox and type
"about:plug-ins" in the URL. Notice that the plugger plug-in isn't
listed.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-11-06 19:10:31 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Henrik Brix Andersen 2006-11-06 19:22:36 UTC
Sorry, forgot to bump PORTREVISION in the previous patch, here's an
updated version:

--- ports/www/plugger/Makefile.orig	Mon Nov  6 19:38:44 2006
+++ ports/www/plugger/Makefile	Mon Nov  6 20:02:17 2006
@@ -7,14 +7,13 @@
 
 PORTNAME=	plugger
 PORTVERSION=	5.1.3
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	www audio graphics multimedia
 MASTER_SITES=	http://fredrik.hubbe.net/plugger/
 
 MAINTAINER=	conrads@cox.net
 COMMENT=	A multimedia front-end plugin for Mozilla or Opera
 
-USE_X_PREFIX=	yes
 GNU_CONFIGURE=	yes
 
 MAN7=		plugger.7

-- 
Henrik Brix Andersen <henrik@brixandersen.dk>
Comment 3 Rong-En Fan freebsd_committer freebsd_triage 2006-11-06 19:49:39 UTC
Responsible Changed
From-To: freebsd-ports-bugs->rafan

Eat.
Comment 4 Rong-En Fan 2006-11-06 19:53:08 UTC
On Mon, Nov 06, 2006 at 08:01:34PM +0100, Henrik Brix Andersen wrote:
> >Fix:
> The patch below moves www/plugger from X11BASE to LOCALBASE.
> 	
> 
> --- plugger.diff begins here ---
> --- ports/www/plugger/Makefile.orig	Mon Nov  6 19:38:44 2006
> +++ ports/www/plugger/Makefile	Mon Nov  6 19:39:05 2006
> @@ -14,7 +14,6 @@
>  MAINTAINER=	conrads@cox.net
>  COMMENT=	A multimedia front-end plugin for Mozilla or Opera
>  
> -USE_X_PREFIX=	yes

I think this should be replaced by USE_XLIB since this port 
requires some headers from X libraries.
Comment 5 Henrik Brix Andersen 2006-11-06 20:27:08 UTC
On Tue, Nov 07, 2006 at 03:53:08AM +0800, Rong-En Fan wrote:
> On Mon, Nov 06, 2006 at 08:01:34PM +0100, Henrik Brix Andersen wrote:
> > >Fix:
> > The patch below moves www/plugger from X11BASE to LOCALBASE.
> > 	
> > 
> > --- plugger.diff begins here ---
> > --- ports/www/plugger/Makefile.orig	Mon Nov  6 19:38:44 2006
> > +++ ports/www/plugger/Makefile	Mon Nov  6 19:39:05 2006
> > @@ -14,7 +14,6 @@
> >  MAINTAINER=	conrads@cox.net
> >  COMMENT=	A multimedia front-end plugin for Mozilla or Opera
> >  
> > -USE_X_PREFIX=	yes
> 
> I think this should be replaced by USE_XLIB since this port 
> requires some headers from X libraries.

Good call.

Regards,
Brix
-- 
Henrik Brix Andersen <henrik@brixandersen.dk>
Comment 6 Rong-En Fan freebsd_committer freebsd_triage 2006-11-21 07:03:57 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 7 dfilter service freebsd_committer freebsd_triage 2006-11-21 07:03:59 UTC
rafan       2006-11-21 07:03:51 UTC

  FreeBSD ports repository

  Modified files:
    www/plugger          Makefile 
  Log:
  - Chase GECKO moved to LOCALBASE
  - Bump PORTREVISION
  
  PR:             ports/105218
  Submitted by:   Henrik Brix Andersen <henrik at brixandersen.dk>
  Approved by:    maintainer timeout (14 days)
  
  Revision  Changes    Path
  1.32      +2 -2      ports/www/plugger/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"