Bug 106389 - [patch] multimedia/mplayer add WITH_NAS knob and other improvements
Summary: [patch] multimedia/mplayer add WITH_NAS knob and other improvements
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Gabor Kovesdan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-05 21:00 UTC by Pawel Pekala
Modified: 2006-12-25 20:00 UTC (History)
1 user (show)

See Also:


Attachments
mplayer.diff (2.45 KB, patch)
2006-12-05 21:00 UTC, Pawel Pekala
no flags Details | Diff
mplayer.diff (1.99 KB, patch)
2006-12-21 21:09 UTC, Thomas E. Zander
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Pekala 2006-12-05 21:00:21 UTC

- add  WITH_NAS knob 
(if  audio/nas is installed mplayer links to libaudio and missed dependency occurs)

- remove WITH_SKINS, make it on by default when WITH_GUI is defined 
(gmplayer needs default skin to run, other idea would be to install default skin in mplayer port and leave other skins in multimedia/mplayer-skins - possibly even better choice?)

- add desktop entry if WITH_GUI is defined

- change some renamed configure options
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-12-05 21:00:59 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Gabor Kovesdan freebsd_committer freebsd_triage 2006-12-06 20:37:47 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gabor

Take.
Comment 3 Gabor Kovesdan freebsd_committer freebsd_triage 2006-12-20 11:40:28 UTC
State Changed
From-To: feedback->open

Maintainer timeout.
Comment 4 Gabor Kovesdan freebsd_committer freebsd_triage 2006-12-20 22:15:11 UTC
State Changed
From-To: open->suspended

multimedia/mplayer-skins doesn't build, this port should be fixed first, 
mark this PR suspended for the meantime. 
A log about the issue is available here: 
http://people.freebsd.org/~gabor/logs/mplayer-skins-1.1.2_5.log
Comment 5 Thomas E. Zander 2006-12-21 21:09:44 UTC
Hi,

Patch is actually alright.
There is just one thing. I particularly like to give the user the
opportunity to select dependency on skins because I know there are
users who want to compile GUI support into mplayer but do not install
skins system-wide, instead only in their ~ .
I slightly modified the patch to allow this. The patch with this tiny
modification is attached and I would appreciate for it to be committed.

Thanks again,
Riggs

-- 
- "[...] I talked to the computer at great length and
-- explained my view of the Universe to it" said Marvin.
--- And what happened?" pressed Ford.
---- "It committed suicide." said Marvin.
Comment 6 Gabor Kovesdan freebsd_committer freebsd_triage 2006-12-22 13:24:31 UTC
State Changed
From-To: suspended->open

Dependency has been fixed.
Comment 7 dfilter service freebsd_committer freebsd_triage 2006-12-25 19:55:42 UTC
gabor       2006-12-25 19:55:35 UTC

  FreeBSD ports repository

  Modified files:
    multimedia/mplayer   Makefile 
  Log:
  - Add WITH_NAS knob
  - Remove WITH_SKINS, make it on by default when WITH_GUI is defined
  - Add desktop entry if WITH_GUI is defined
  - Change some renamed configure options
  - Bump PORTREVISION
  
  PR:             ports/106389
  Submitted by:   Pawel Pekala <c0rn@o2.pl> (with changes from maintainer)
  Approved by:    erwin (mentor),
                  Thomas E. Zander <riggs@rrr.de> (maintainer)
  
  Revision  Changes    Path
  1.150     +17 -6     ports/multimedia/mplayer/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 8 Gabor Kovesdan freebsd_committer freebsd_triage 2006-12-25 19:56:32 UTC
State Changed
From-To: open->closed

Committed with a slight change, thanks! 
(PORTREVISION should be bumped on changes in behavior/dependency)