Bug 106512 - databases/slony1: package list fixes
Summary: databases/slony1: package list fixes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-09 11:20 UTC by Robert Gogolok
Modified: 2006-12-13 07:40 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Gogolok 2006-12-09 11:20:14 UTC
* sbin/slon-mkservice is mentioned twice
* 2 altperl scripts are not specified
* %%PORTDOCS%% usage: at least the adminguide and the howto should not be installed in case of NOPORTDOCS=yes

Fix: 

http://w5.cs.uni-sb.de/~gogo/patches/slony1-1.2.1.patch
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-12-09 11:21:13 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Martin Wilke freebsd_committer freebsd_triage 2006-12-09 11:34:25 UTC
Responsible Changed
From-To: freebsd-ports-bugs->miwi

I'll take it.
Comment 3 Vick Khera 2006-12-11 16:03:15 UTC
On Dec 9, 2006, at 6:21 AM, Edwin Groothuis wrote:

> Maintainer of databases/slony1,
>
> Please note that PR ports/106512 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/106512

Firstly, how did slony1 port get to version 1.2.1 without my approval  
or notification?

I suppose you should go ahead and apply this patch to clean up the  
plist.  It looks like "miwi" did the commit against ports system  
policy of getting approval of the maintainer.
Comment 4 Martin Wilke freebsd_committer freebsd_triage 2006-12-11 17:03:34 UTC
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Mon, 11 Dec 2006 16:10:21 GMT
Vivek Khera <vivek@khera.org> wrote:

>  
>  Firstly, how did slony1 port get to version 1.2.1 without my
> approval or notification?
>  


Sorry, it was definietly my fault. I thought its a maintainer-timeout
case. It was my mistake and I hope you forgive me for this mistake.


>  I suppose you should go ahead and apply this patch to clean up the  
>  plist.  It looks like "miwi" did the commit against ports system  
>  policy of getting approval of the maintainer.
>  


Yes the policy said we wait 14 days of Maintainer approval. :(( Big
sorry for this. 

The Contributor contacted me with email, and I just forgot to double
check this PR with maintainer.


- - Martin



- -- 
Martin Wilke		| irc.unixfreunde.de #bsd 
miwi@FreeBSD.org	| miwi@unixfreunde.de
FreeBSD Committer	| Power to Serve
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (FreeBSD)

iD8DBQFFfY9mPrCIFpjWZiwRAjkkAKDVXpDB4Ihc/KTB6jD7KECWpOHzdwCgwmbX
0QSTH14kEmH5cJ6vmRAq0Qg=
=miGI
-----END PGP SIGNATURE-----
Comment 5 dfilter service freebsd_committer freebsd_triage 2006-12-13 07:38:01 UTC
miwi        2006-12-13 07:37:49 UTC

  FreeBSD ports repository

  Modified files:
    databases/slony1     pkg-plist 
  Log:
  - Fix pkg-plist
  
  PR:             ports/106512
  Submitted by:   Robert Gogolok<gogo@cs.uni-sb.de>
  Approved by:    Vivek Khera <vivek@khera.org> (maintainer)
  
  Revision  Changes    Path
  1.9       +241 -240  ports/databases/slony1/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Martin Wilke freebsd_committer freebsd_triage 2006-12-13 07:38:02 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!