Bug 107372 - Mk/bsd.tcl.mk: add USE_TK_BUILD.
Summary: Mk/bsd.tcl.mk: add USE_TK_BUILD.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-31 11:00 UTC by Thierry Thomas
Modified: 2007-01-08 00:10 UTC (History)
0 users

See Also:


Attachments
bsd.tcl.mk.diff (1.36 KB, patch)
2006-12-31 11:00 UTC, Thierry Thomas
no flags Details | Diff
file.diff (405 bytes, patch)
2006-12-31 11:00 UTC, Thierry Thomas
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thierry Thomas freebsd_committer freebsd_triage 2006-12-31 11:00:28 UTC
	- USE_TCL_BUILD exists, but USE_TK_BUILD is missing: when defined, it
	adds a LIB_DEPENDS on libtkxy.

	- Change a bit in Mk/bsd.port.mk to take it into account.

Fix: Please apply the following patches:
How-To-Repeat: 	N/A.
Comment 1 Thierry Thomas freebsd_committer freebsd_triage 2006-12-31 11:10:33 UTC
Responsible Changed
From-To: freebsd-ports-bugs->portmgr


Assign to portmgr, because it includes a little change in Mk/bsd.port.mk.
Comment 2 Pav Lucistnik freebsd_committer freebsd_triage 2006-12-31 12:08:02 UTC
Looks very similar to what I have at ~pav/tcl-Mk.diff

But guess my patch is more thorought, you missed a second occurence in
bsd.port.mk, for example.

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

Ah I don't know what you mean, so I'll just sit here and smile at you :)
Comment 3 Thierry Thomas freebsd_committer freebsd_triage 2006-12-31 13:12:11 UTC
Le Dim 31 déc 06 à 13:08:02 +0100, Pav Lucistnik <pav@FreeBSD.org>
 écrivait :
> Looks very similar to what I have at ~pav/tcl-Mk.diff

The main difference is that you set a BUILD_DEPENDS while I prefer a
LIB_DEPENDS.

> But guess my patch is more thorought, you missed a second occurence in
> bsd.port.mk, for example.

You're right ;-) I have tested it with ports that only used the first
occurrence... If you commit yours, feel free to close my PR.

Regards,
-- 
Th. Thomas.
Comment 4 Pav Lucistnik freebsd_committer freebsd_triage 2006-12-31 13:21:32 UTC
> > Looks very similar to what I have at ~pav/tcl-Mk.diff
> 
> The main difference is that you set a BUILD_DEPENDS while I prefer a
> LIB_DEPENDS.

Because you may want to have tcl as a build tool only.

> > But guess my patch is more thorought, you missed a second occurence in
> > bsd.port.mk, for example.
> 
> You're right ;-) I have tested it with ports that only used the first
> occurrence... If you commit yours, feel free to close my PR.

That's my plan.

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

If God didn't mean for us to juggle, tennis balls wouldn't come three
to a can.
Comment 5 Thierry Thomas freebsd_committer freebsd_triage 2006-12-31 15:24:17 UTC
Le Dim 31 déc 06 à 14:21:32 +0100, Pav Lucistnik <pav@FreeBSD.org>
 écrivait :

> > The main difference is that you set a BUILD_DEPENDS while I prefer a
> > LIB_DEPENDS.
> 
> Because you may want to have tcl as a build tool only.

Do we really have such ports? Usually these ports either need wish /
tclsh or a dynamic library to run.

Regards,
-- 
Th. Thomas.
Comment 6 Pav Lucistnik freebsd_committer freebsd_triage 2006-12-31 17:10:35 UTC
> > > The main difference is that you set a BUILD_DEPENDS while I prefer a
> > > LIB_DEPENDS.
> > 
> > Because you may want to have tcl as a build tool only.
> 
> Do we really have such ports? Usually these ports either need wish /
> tclsh or a dynamic library to run.

That's beside the point. At the present time, there is no way to do such
a port using macros.

Best would be to change it to resemble perl macros (USE_TCL,
USE_TCL_RUN, USE_TCL_BUILD) but that's probably not possible now, when
it's already widely used.

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

On second thought, let's not go to Camelot. It is a silly place.
Comment 7 Thierry Thomas freebsd_committer freebsd_triage 2006-12-31 17:59:03 UTC
Le Dim 31 déc 06 à 18:10:35 +0100, Pav Lucistnik <pav@FreeBSD.org>
 écrivait :
> > > > The main difference is that you set a BUILD_DEPENDS while I prefer a
> > > > LIB_DEPENDS.
> > > 
> > > Because you may want to have tcl as a build tool only.
> > 
> > Do we really have such ports? Usually these ports either need wish /
> > tclsh or a dynamic library to run.
> 
> That's beside the point. At the present time, there is no way to do such
> a port using macros.
> 
> Best would be to change it to resemble perl macros (USE_TCL,
> USE_TCL_RUN, USE_TCL_BUILD) but that's probably not possible now, when
> it's already widely used.

USE_TCL_BUILD is currently BROKEN, or at least unuseful.

For example, let's examine the port databases/mysqltcl: the maintainer
defined both USE_TCL and USE_TCL_BUILD, because he wants LIB_DEPENDS,
but he only gets a BUILD_DEPENDS:

cd /usr/ports/databases/mysqltcl
grep USE_TCL Makefile
USE_TCL=        yes
USE_TCL_BUILD=  yes
make run-depends-list
/usr/ports/databases/mysql50-client

As you said, it's difficult to fix TCL because it's already used, but we
could do it right directly for USE_TK_BUILD.

Best regards - and happy new year!
-- 
Th. Thomas.
Comment 8 Pav Lucistnik freebsd_committer freebsd_triage 2006-12-31 18:03:33 UTC
> > Best would be to change it to resemble perl macros (USE_TCL,
> > USE_TCL_RUN, USE_TCL_BUILD) but that's probably not possible now, when
> > it's already widely used.
> 
> USE_TCL_BUILD is currently BROKEN, or at least unuseful.
> 
> For example, let's examine the port databases/mysqltcl: the maintainer
> defined both USE_TCL and USE_TCL_BUILD, because he wants LIB_DEPENDS,
> but he only gets a BUILD_DEPENDS:
> 
> cd /usr/ports/databases/mysqltcl
> grep USE_TCL Makefile
> USE_TCL=        yes
> USE_TCL_BUILD=  yes
> make run-depends-list
> /usr/ports/databases/mysql50-client
> 
> As you said, it's difficult to fix TCL because it's already used, but we
> could do it right directly for USE_TK_BUILD.

Yes, at the moment having both USE_TCL and USE_TCL_BUILD disables the
run dependency.

After my patch is committed, this port will start behaving as intended
by the author (both BUILD and RUN dep). No need to change the port.

I have changes to several ports that needs to get in together with the
bsd.tcl.mk patch, you can see them on freefall in ~pav/tcl* files

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

Adding horrible bugs to the source is a venal sin.
Comment 9 Pav Lucistnik freebsd_committer freebsd_triage 2007-01-07 23:59:33 UTC
State Changed
From-To: open->closed

Similar, older patch applied.
Comment 10 dfilter service freebsd_committer freebsd_triage 2007-01-08 00:00:43 UTC
pav         2007-01-08 00:00:33 UTC

  FreeBSD ports repository

  Modified files:
    Mk                   bsd.port.mk bsd.tcl.mk 
  Log:
  - Fix USE_TCL_BUILD to not disable runtime dependency on tcl from USE_TCL
  - Add a new knob: USE_TK_BUILD
  - Support a new tcl version: 84-thread
  
  PR:             ports/103897, ports/107372 (based on)
  
  Revision  Changes    Path
  1.545     +3 -3      ports/Mk/bsd.port.mk
  1.5       +30 -9     ports/Mk/bsd.tcl.mk
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"