Bug 107890 - [PATCH] www/youtube_dl: [SUMMARIZE CHANGES]
Summary: [PATCH] www/youtube_dl: [SUMMARIZE CHANGES]
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-13 23:10 UTC by Sergio Lenzi
Modified: 2007-01-23 08:20 UTC (History)
1 user (show)

See Also:


Attachments
youtube_dl-2007.01.01.patch (4.69 KB, patch)
2007-01-13 23:10 UTC, Sergio Lenzi
no flags Details | Diff
youtube_dl.diff (4.55 KB, patch)
2007-01-15 22:27 UTC, Pankov Pavel
no flags Details | Diff
youtube_dl.diff (4.20 KB, patch)
2007-01-20 22:47 UTC, Pankov Pavel
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Lenzi 2007-01-13 23:10:24 UTC
Add an option to recode the movie in avi
using ffmpeg.
option added: --avi
	this options works almost the same as --title
	it extracts the title of the move and recode resulting
	an avi movie (divx + mp3)
[DESCRIBE CHANGES]

Added file(s):
- files/patch-aa

Port maintainer (pankov_p@mail.ru) is cc'd.

Generated with FreeBSD Port Tools 0.77
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-01-13 23:10:36 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Pankov Pavel 2007-01-15 22:27:29 UTC
Thanks! I reworked your patch and added one more :)

Changes:
- Don't create file with one name and then rename it to other. As
   the final name is known at the creation time I see no reason for
   such renaming.
- Added an optional patch, which adds new option --avi(-a) to
   create .avi (divx + mp3) file instead of .flv using
   multimedia/ffmpeg (lenzi at k1.com.br)
Comment 3 Martin Wilke freebsd_committer freebsd_triage 2007-01-17 01:27:57 UTC
Responsible Changed
From-To: freebsd-ports-bugs->miwi

I'll take it.
Comment 4 Pankov Pavel 2007-01-20 22:47:40 UTC
New version (2007.01.19) is out. Here is the new patch. no-rename.patch 
dropped because of --title option breakage.
Comment 5 Martin Wilke freebsd_committer freebsd_triage 2007-01-21 09:00:36 UTC
LS0tLS1CRUdJTiBQR1AgU0lHTkVEIE1FU1NBR0UtLS0tLQ0KSGFzaDogU0hBMQ0KDQpPbiBTdW4s
IDIxIEphbiAyMDA3IDAxOjQ3OjQwICswMzAwDQpQYW5rb3YgUGF2ZWwgPHBhbmtvdl9wQG1haWwu
cnU+IHdyb3RlOg0KDQp8TmV3IHZlcnNpb24gKDIwMDcuMDEuMTkpIGlzIG91dC4gSGVyZSBpcyB0
aGUgbmV3IHBhdGNoLg0KfG5vLXJlbmFtZS5wYXRjaCBkcm9wcGVkIGJlY2F1c2Ugb2YgLS10aXRs
ZSBvcHRpb24gYnJlYWthZ2UuDQoNCkhpIFBhbmtvdiwNCg0KY2FuIHlvdSBwbGVhc2UgcmVuYW1l
IHRoZSBwYXRjaGVzIHRvIA0KcGF0Y2gtKiA/IHBsZWFzZSBzaG93IGluIHRoZSBwb3J0ZXIgYm9v
ayBmb3IgdGhpcy4NCg0KaHR0cDovL3d3dy5mcmVlYnNkLm9yZy9kb2MvZW5fVVMuSVNPODg1OS0x
L2Jvb2tzL3BvcnRlcnMtaGFuZGJvb2svc2xvdy1wYXRjaC5odG1sDQoNClBsZWFzZSBjaGVjayBh
ZnRlciB0aGUgcmVuYW1lIHRoZSBwYXRjaHNldCB0aGlzIGZhaWxlZC4NCg0KLSAtLSANCk1hcnRp
biBXaWxrZQkJfCBpcmMudW5peGZyZXVuZGUuZGUgI2JzZCANCm1pd2lARnJlZUJTRC5vcmcJfCBt
aXdpQHVuaXhmcmV1bmRlLmRlDQpGcmVlQlNEIENvbW1pdHRlcgl8IFBvd2VyIHRvIFNlcnZlDQot
LS0tLUJFR0lOIFBHUCBTSUdOQVRVUkUtLS0tLQ0KVmVyc2lvbjogR251UEcgdjEuNC42IChGcmVl
QlNEKQ0KDQppRDhEQlFGRnN5dTBQckNJRnBqV1ppd1JBcWpjQUtDUGtjMUQ3TFIwVHBVMDhsT1ZF
TkdCVTNHaFhBQ2cwUkJ6DQpuUi9rdGQwQi9QT0JkYXRYV2hONWhTST0NCj1Dc0d5DQotLS0tLUVO
RCBQR1AgU0lHTkFUVVJFLS0tLS0NCg==
Comment 6 Pankov Pavel 2007-01-21 20:52:46 UTC
Martin Wilke ?????:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On Sun, 21 Jan 2007 01:47:40 +0300
> Pankov Pavel <pankov_p@mail.ru> wrote:
> 
> |New version (2007.01.19) is out. Here is the new patch.
> |no-rename.patch dropped because of --title option breakage.
> 
> Hi Pankov,
> 
> can you please rename the patches to 
> patch-* ? please show in the porter book for this.

Hi. Yes, I can rename it, but, if I understand code in bsd.port.mk 
correctly, patches with names patch-* in ${PATCHDIR} are automatically 
applied. Thus, youtube-dl will always have the --avi switch, which 
requires ffmpeg binary to be present and I'd like that this dependency 
to be optional, as youtube-dl can be used without it perfectly. As I can 
see, for example, www/squid port uses the same trick to make some 
patches optional. But if you insist, I'll rename them and remove such a 
conditional dependency...
> 
> http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/slow-patch.html
> 
> Please check after the rename the patchset this failed.
> 
> - -- 
> Martin Wilke		| irc.unixfreunde.de #bsd 
> miwi@FreeBSD.org	| miwi@unixfreunde.de
> FreeBSD Committer	| Power to Serve
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (FreeBSD)
> 
> iD8DBQFFsyu0PrCIFpjWZiwRAqjcAKCPkc1D7LR0TpU08lOVENGBU3GhXACg0RBz
> nR/ktd0B/POBdatXWhN5hSI=
> =CsGy
> -----END PGP SIGNATURE-----
Comment 7 dfilter service freebsd_committer freebsd_triage 2007-01-23 08:12:56 UTC
miwi        2007-01-23 08:12:49 UTC

  FreeBSD ports repository

  Modified files:
    www/youtube_dl       Makefile distinfo 
  Added files:
    www/youtube_dl/files ffmpeg.patch 
  Log:
  - Update to 2007.01.09 [1]
  - Add an options to recode the movie in avi
  
  PR:             ports/107890
  Submitted by:   Sergio Lenzi <lenzi@k1.com.br>
                  Pankov Pavel <pankov_p@mail.ru> [1] (maintainer)
  
  Revision  Changes    Path
  1.8       +11 -2     ports/www/youtube_dl/Makefile
  1.8       +3 -3      ports/www/youtube_dl/distinfo
  1.1       +59 -0     ports/www/youtube_dl/files/ffmpeg.patch (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 8 Martin Wilke freebsd_committer freebsd_triage 2007-01-23 08:14:13 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!