- Remove CONFIGURE_ENV from Makefile, configure picks this up itself - Retire patch-pty_termios.c Fix: Makefile revision 1.61 introduced "LDFLAGS -lutil" to CONFIGURE_ENV to solve a build error. This problem has since been fixed upstream in the configure script which now checks for -lutil. However, the CONFIGURE_ENV in our Makefile now causes the HAVE_OPENPTY #define in expect_cf.h to be dropped, leading to openpty() no longer being used, and PTY_TYPE to be termios (legacy). This is the root cause of the "only 64 pty's" problem that was worked around with the patch-pty_termios.c patch introduced at the PORTREVISION bump in Makefile 1.70. The patch only corrects the symptom (wrong master/slave pty names in pty_termios.c) not the root cause, as Expect should not be using termios at all but rather openpty() which supports any number of pty's available on the system and is POSIX supported. Removing the now unnecessary CONFIGURE_ENV allows the configure script to correctly pick up HAVE_OPENPTY and use openpty() instead. /leg
Responsible Changed From-To: freebsd-ports-bugs->shaun Over to maintainer
Has this been forgotten? Should be a no-brainer, as this restores the old behaviour, that was broken by accident a few versions ago. /leg
State Changed From-To: open->closed Nice catch; Committed. Sorry for the delay.
shaun 2007-03-27 23:59:22 UTC FreeBSD ports repository Modified files: lang/expect Makefile Removed files: lang/expect/files patch-pty_termios.c Log: Let expect detect and use openpty(3), and therefore allow it to utilise as many ptys as we support. The breakage was caused by a bogus (or temporarily introduced) CONFIGURE_ENV. PR: ports/108311 Submitted by: Lars Erik Gullerud <lerik@nolink.net> Revision Changes Path 1.72 +1 -2 ports/lang/expect/Makefile 1.2 +0 -20 ports/lang/expect/files/patch-pty_termios.c (dead) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"