Bug 108339 - [fix] security/tor and security/tor-devel use pre-install instead of pre-su-install
Summary: [fix] security/tor and security/tor-devel use pre-install instead of pre-su-i...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rong-En Fan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-25 16:20 UTC by Michael Neumann
Modified: 2007-02-12 13:40 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Neumann 2007-01-25 16:20:20 UTC 
security/tor and security/tor-devel user pre-install to add an user and a group to the system. This fails when running `make install` as normal user.

Fix: 

Change pre-install to pre-su-install in both ports.
How-To-Repeat: run `make install` as normal user
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-01-25 16:21:07 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Peter Thoenen 2007-01-25 17:15:03 UTC 
I was both unaware a pre-su-install stage existed OR that normal users
could install ports period (via make install in the ports tree).

Regardless installing the tor port as a non-su user will break the port
period as it installs both a _tor user and _tor group.

If the reporter wishes to be able to install this port as a normal user
AND the committers don't find this to be a security issue, the the
orginal PR submitter needs to provide a patch that will account for
this (e.g. with some custom make options that modify things like
pkg-install so _tor users don't get installed, chown issues, etc etc).

Or just download and install it manually ... gmake && gmake install
Comment 3 mneuma2s 2007-01-25 22:33:26 UTC 
When started as a normal user `make install` will ask for the rootpw to su as
root. This happens after the pre-install but before the pre-su-install target.
The port will be able to create the user/group when they're created in the
pre-su-install target.
Comment 4 Peter Thoenen 2007-01-25 22:56:13 UTC 
In that case, I will include this change then when the next version is 
released.

-Peter
Comment 5 Peter Thoenen 2007-02-09 19:04:34 UTC 
Closed in PR 108966

http://www.freebsd.org/cgi/query-pr.cgi?pr=108966&cat=

Thanks for pointing this out, never actually new that existed and
missed the dicussion on the list about it.
Comment 6 Rong-En Fan freebsd_committer freebsd_triage 2007-02-12 13:07:32 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->rafan

Eat.
Comment 7 Rong-En Fan freebsd_committer freebsd_triage 2007-02-12 13:34:05 UTC 
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 8 dfilter service freebsd_committer freebsd_triage 2007-02-12 13:34:06 UTC 
rafan       2007-02-12 13:33:56 UTC

  FreeBSD ports repository

  Modified files:
    security/tor         Makefile 
  Log:
  - Use pre-su-install to allow make install as normal user
  
  PR:             ports/108339
  Submitted by:   Michael Neumann<mneuma2s at smail.inf.fh-brs.de>
  Approved by:    Peter Thoenen <peter.thoenen at yahoo.com> (maintainer)
  
  Revision  Changes    Path
  1.27      +1 -1      ports/security/tor/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"