Bug 109096 - [PATCH] mpd4 rc-script bug
Summary: [PATCH] mpd4 rc-script bug
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Alejandro Pulver
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-12 17:10 UTC by Volker
Modified: 2007-02-17 04:51 UTC (History)
0 users

See Also:

Attachments
file.diff (259 bytes, patch)
2007-02-12 17:10 UTC, Volker 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Volker 2007-02-12 17:10:23 UTC 
latest mpd4 (4.1) installs a bugged rc script.

When using mpd_flags in /etc/rc.conf starting up mpd4 fails with:
Starting mpd4.
Usage: mpd [options] [system]
Options:
  -b, --background                      Run as a background daemon
  -d, --directory config-dir            Set config file directory
  -k, --kill                            Kill running mpd process before start
  -f, --file config-file                Set configuration file
  -p, --pidfile filename                Set PID filename
  -s, --syslog-ident ident              Identifier to use for syslog
  -v, --version                         Show version information
  -h, --help                            Show usage information

as the parameter -p ${pidfile} is being set wrong in the rc-script.

Please see attached patch.

How-To-Repeat: use mpd_flags="anything-goes-to-mpd4" in /etc/rc.conf
start /usr/local/etc/rc.d/mpd4
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-02-12 20:43:11 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Alexander Motin 2007-02-12 21:29:43 UTC 
This happens when "system" parameter is specified in mpd_flags.

I agree with this patch.
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2007-02-13 01:13:31 UTC 
State Changed
From-To: feedback->open

Maintainer approved.
Comment 4 Alejandro Pulver freebsd_committer freebsd_triage 2007-02-17 04:22:45 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->alepulver

I'll take it.
Comment 5 Alejandro Pulver freebsd_committer freebsd_triage 2007-02-17 04:51:00 UTC 
State Changed
From-To: open->closed

Committed. Thanks!