Bug 109673 - net/bacula-server doesn't honor PREFIX
Summary: net/bacula-server doesn't honor PREFIX
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Frank J. Laszlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-28 13:00 UTC by andrew
Modified: 2007-03-01 10:50 UTC (History)
0 users

See Also:


Attachments
bacula-prefix.diff (1.88 KB, patch)
2007-02-28 20:33 UTC, Dan Langille
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description andrew 2007-02-28 13:00:19 UTC
	Port "net/bacula-server" doesn't honor PREFIX seiing

Fix: bagheera# cvs diff -u bacula-sd.in


name="bacula_sd"
 rcvar=`set_rcvar`
-command=/usr/local/sbin/bacula-sd
+command=%%PREFIX%%/sbin/bacula-sd

 load_rc_config $name

 pidfile="${bacula_sd_pidfile}"

 : ${bacula_sd_enable="NO"}
-: ${bacula_sd_flags=" -u bacula -g bacula -v -c /usr/local/etc/bacula-sd.conf"}
+: ${bacula_sd_flags=" -u bacula -g bacula -v -c %%PREFIX%%/etc/bacula-sd.conf"}
 : ${bacula_sd_pidfile="/var/run/bacula-sd.9103.pid"}

 run_rc_command "$1"
bagheera#--yuu9LV9iEQqetrHL7SOG233b5gCyhpBY6PndWCdwPxrr8tbF
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

Index: bacula-sd.in
===================================================================
RCS file: /home/ncvs/ports/sysutils/bacula-server/files/bacula-sd.in,v
retrieving revision 1.2
diff -u -r1.2 bacula-sd.in
--- bacula-sd.in        4 Jan 2007 23:22:30 -0000       1.2
+++ bacula-sd.in        28 Feb 2007 12:41:12 -0000
@@ -18,14 +18,14 @@
How-To-Repeat: 	Just build port with PREFIX set to something other than "/usr/local" and try to start Bacula storage daemon.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-02-28 20:02:18 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Dan Langille 2007-02-28 20:33:59 UTC
Good catch!

I see bacula-fd.in has the same problem.  Attached is a patch that bumps
portversion, and patches bacula-sd.in and bacula-fd.in

Thank you.



-- 
Dan Langille - http://www.langille.org/
BSDCan - The Technical BSD Conference: http://www.bsdcan.org/
Comment 3 Frank J. Laszlo freebsd_committer freebsd_triage 2007-02-28 20:57:23 UTC
Responsible Changed
From-To: freebsd-ports-bugs->laszlof

I'll take it.
Comment 4 dfilter service freebsd_committer freebsd_triage 2007-02-28 21:13:24 UTC
laszlof     2007-02-28 21:13:11 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/bacula-server Makefile 
    sysutils/bacula-server/files bacula-fd.in bacula-sd.in 
  Log:
  respect PREFIX.
  bump PORTREVISION
  
  PR:             ports/109673
  Submitted by:   Andrew Kolchoogin <andrew@rinet.ru>
  Approved by:    Dan Langille <dan@langille.org> (maintainer)
  
  Revision  Changes    Path
  1.81      +1 -0      ports/sysutils/bacula-server/Makefile
  1.3       +3 -3      ports/sysutils/bacula-server/files/bacula-fd.in
  1.3       +3 -3      ports/sysutils/bacula-server/files/bacula-sd.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Frank J. Laszlo freebsd_committer freebsd_triage 2007-02-28 21:13:25 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 6 Oliver Lehmann freebsd_committer freebsd_triage 2007-03-01 10:46:38 UTC
files/bacula-fd.in is now broken... 

command=%%PREFIX%%sbin/bacula-fd 

will not work. It has to be 

command=%%PREFIX%%/sbin/bacula-fd 

as it was in the original patch. Please fix this.