the linux-megacli port was a bit hard to get running because it wasn't checking all prereqs. Further it already gave good info on what to do so it was even more confusing. Checking for empty directories to exist wasn't really great, especially if paths did not match. Redirect error information to stderr instead of giving it on stdout. A periodic script for daily mails about raid states was missing. Fix: In addition to the attached patch I also copied it to http://sources.zabbadoz.net/freebsd/ports/experimental/ file name sysutils-linux-megacli-03.diff for easy access. It's hardly tested. The 407 daily script tries to do what was done for amrstat and tw_cli before. [ you may ignore the whitespace cahnges ;-) ]
State Changed From-To: open->feedback Awaiting maintainers feedback
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Ok, looks good and 407.status-mfi-raid works as advertised on our Dell PE2950. Thing do, the three letter abbreviations should have a legend somewhere, a README-status-mfi-raid.txt would be appropriate in ${DOCSDIR} can the author of the patch provide such document ? Thanks! Ruben On 2 Mar 2007, at 21:35, Edwin Groothuis wrote: > Maintainer of sysutils/linux-megacli, > > Please note that PR ports/109753 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/109753 > > -- > Edwin Groothuis > edwin@FreeBSD.org -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (Darwin) iD8DBQFF6cvLZ88+mcQxRw0RAqj9AJoDxAqME9Accpdk4OjkLeq0EgjMdQCfTMhv Bt/uQNlLJ+OFXnKbhej553c= =XCpw -----END PGP SIGNATURE-----
I have updated the patch on the website. http://sources.zabbadoz.net/freebsd/ports/experimental/ Version 04 now also has a short README that just maps back the abbrevs to the names MegaCli uses: http://sources.zabbadoz.net/freebsd/ports/experimental/sysutils-linux-megacli-04.diff
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 5 Mar 2007, at 14:49, Bjoern A. Zeeb wrote: > http://sources.zabbadoz.net/freebsd/ports/experimental/sysutils- > linux-megacli-04.diff Ok looks good to me. I approve the patch Thanks! - - Ruben -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (Darwin) iD8DBQFF7n4QZ88+mcQxRw0RAk/NAJ9wNW63pIvKB6xt2XNzyMe0apSNRACfZ4Bt R2lEZpvSPpCJR6ACHuvXe4Y= =yjM/ -----END PGP SIGNATURE-----
State Changed From-To: feedback->open Maintainer approved.
Responsible Changed From-To: freebsd-ports-bugs->rafan Eat.
rafan 2007-03-09 13:15:02 UTC FreeBSD ports repository Modified files: sysutils/linux-megacli Makefile pkg-message pkg-plist sysutils/linux-megacli/files megacli.sh.in Added files: sysutils/linux-megacli/files 407.status-mfi-raid.in README-status-mfi-raid.txt Log: - Add periodic script that reports raid status - Update pkg-message - Correct prerequisite checks in script - Bump PORTREVISION PR: ports/109753 Submitted by: Bjoern A. Zeeb <bzeeb+freebsdports at zabbadoz.net> Approved by: Ruben van Staveren <ruben at verweg.com> (maintainer) Revision Changes Path 1.4 +6 -0 ports/sysutils/linux-megacli/Makefile 1.1 +227 -0 ports/sysutils/linux-megacli/files/407.status-mfi-raid.in (new) 1.1 +42 -0 ports/sysutils/linux-megacli/files/README-status-mfi-raid.txt (new) 1.2 +17 -6 ports/sysutils/linux-megacli/files/megacli.sh.in 1.2 +13 -4 ports/sysutils/linux-megacli/pkg-message 1.2 +4 -0 ports/sysutils/linux-megacli/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks!