Bug 110386 - net/openldap*: Use <termios.h> when available
Summary: net/openldap*: Use <termios.h> when available
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Xin LI
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-16 13:00 UTC by Ed Schouten
Modified: 2007-04-10 17:30 UTC (History)
0 users

See Also:


Attachments
file.diff (602 bytes, patch)
2007-03-16 13:00 UTC, Ed Schouten
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Schouten 2007-03-16 13:00:26 UTC
OpenLDAP's configure scripts see if <termios.h> and <sgtty.h> are
available. For some reason, no checks for HAVE_TERMIOS_H are done in the
sourcecode, HAVE_POSIX_TERMIOS is done instead. This causes OpenLDAP to
use <sgtty.h>, which breaks when a kernel without COMPAT_43TTY is used.

Fix: Place the following file in net/openldap23-server/files/ and
net/openldap24-server/files/:
Comment 1 Martin Wilke freebsd_committer freebsd_triage 2007-03-16 13:45:43 UTC
Responsible Changed
From-To: freebsd-ports-bugs->delphij

Over to maintainer.
Comment 2 Xin LI freebsd_committer freebsd_triage 2007-03-20 14:17:58 UTC
State Changed
From-To: open->feedback

Dear submitter, 

I think the change is useful for OpenLDAP in general, no matter 
which operating system.  Would you mind submitting this patch 
back to the OpenLDAP authors to see if they can accept it? 

I will add your patch if the next OpenLDAP release does not come 
with this change. 

Thanks for your submission!
Comment 3 Xin LI freebsd_committer freebsd_triage 2007-03-20 15:10:29 UTC
State Changed
From-To: feedback->open

Submitter has already submitted ticket 4880 for OpenLDAP.
Comment 4 Ed Schouten 2007-04-10 10:28:48 UTC
* Xin LI <delphij@FreeBSD.org> wrote:
> I will add your patch if the next OpenLDAP release does not come
> with this change.


I just looked through the OpenLDAP 2.3.35 tarball, which got released
yesterday. The bug hasn't been fixed.

-- 
 Ed Schouten <ed@fxq.nl>
 WWW: http://g-rave.nl/
Comment 5 dfilter service freebsd_committer freebsd_triage 2007-04-10 15:23:08 UTC
delphij     2007-04-10 14:23:02 UTC

  FreeBSD ports repository

  Modified files:
    net/openldap23-server Makefile distinfo 
  Added files:
    net/openldap23-server/files patch-43tty 
  Log:
   - Update to 2.3.35
   - Unbreak for kernels without COMPAT_43TTY [1]
  
  Note: the patch from [1] was accepted by OpenLDAP, but
  not yet integrated into there RELENG_2_3 branch.
  
  Submitted by:   Ed Schouten <ed fxq.nl> [1]
  PR:             ports/110386 [1]
  
  Revision  Changes    Path
  1.151     +2 -2      ports/net/openldap23-server/Makefile
  1.72      +3 -3      ports/net/openldap23-server/distinfo
  1.1       +22 -0     ports/net/openldap23-server/files/patch-43tty (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Xin LI freebsd_committer freebsd_triage 2007-04-10 15:34:56 UTC
State Changed
From-To: open->patched

Patched openldap23-server part.  Waiting for next 2.4.x 
release to determine whether we still need to patch it.
Comment 7 dfilter service freebsd_committer freebsd_triage 2007-04-10 17:29:04 UTC
delphij     2007-04-10 16:28:56 UTC

  FreeBSD ports repository

  Added files:
    net/openldap24-server/files patch-43tty 
  Log:
  Unbreak for kernels without COMPAT_43TTY
  
  Note: the patch was accepted by OpenLDAP, but
  not yet integrated into their RELENG_2_4 branch.
  
  Submitted by:   Ed Schouten <ed fxq.nl>
  PR:             ports/110386
  
  Revision  Changes    Path
  1.1       +22 -0     ports/net/openldap24-server/files/patch-43tty (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 8 Xin LI freebsd_committer freebsd_triage 2007-04-10 17:29:14 UTC
State Changed
From-To: patched->closed

Committed, thanks!