Fix FATAL errors noticed by portlint -C: FATAL: Makefile: PORTVERSION looks illegal. You should modify "4.0.5.GA". FATAL: Makefile: The value of the USE_RC_SUBR variable should be the name of the intended rc.d script, and there should be a corresponding file in the files/ directory. Fix: Patch attached with submission follows:
State Changed From-To: open->feedback Awaiting maintainers feedback
One thing that portlint complains about is the non-standard use of the PORTVERSION; but the reason why I've done it that way is because the JBoss people sometimes release versions with xx-SP1, and I don't want to changing "DISTNAME" and "JBOSSOUTPUT" everytime they change from a -GA suffix to a -SPx suffix and back. Also, as the startup.sh file has been removed and re-added, it really should have a "# KEYWORD: shutdown" for rc(8) Please do not commit the patch as it stands. Cheers. -- Jonathan Chen <jonc@chen.org.nz> ----------------------------------------------------------------------- "One, with God, is always a majority, but many a martyr has been burned at the stake while the votes were being counted." -- Thomas B. Reed
I rewrite the patch .this one should be better. such as: change USE_RC_SUBR value to jboss4.sh; use ant to build src; use SUB_FILES and SUB_LIST replace use sed manaully.
Responsible Changed From-To: freebsd-ports-bugs->nemoliu Submitter now have freefall access.
State Changed From-To: feedback->closed superceded by 113192
pav 2007-07-29 20:16:15 UTC FreeBSD ports repository Modified files: java/jboss3 Makefile distinfo Added files: java/jboss3/files daemonctl.1.in daemonctl.c.in jboss3.in patch-build.xml patch-buildmagic.ent pkg-deinstall.in pkg-install.in pkg-message.in Removed files: java/jboss3 pkg-deinstall pkg-install java/jboss3/files daemonctl.1 daemonctl.c pkg-message startup.sh Log: - Update to 3.2.8 PR: ports/110768 Submitted by: nemoliu Approved by: maintainer (previous version, with reservations) Revision Changes Path 1.32 +35 -48 ports/java/jboss3/Makefile 1.14 +3 -3 ports/java/jboss3/distinfo 1.2 +0 -78 ports/java/jboss3/files/daemonctl.1 (dead) 1.1 +78 -0 ports/java/jboss3/files/daemonctl.1.in (new) 1.3 +0 -557 ports/java/jboss3/files/daemonctl.c (dead) 1.1 +557 -0 ports/java/jboss3/files/daemonctl.c.in (new) 1.1 +58 -0 ports/java/jboss3/files/jboss3.in (new) 1.1 +38 -0 ports/java/jboss3/files/patch-build.xml (new) 1.1 +37 -0 ports/java/jboss3/files/patch-buildmagic.ent (new) 1.1 +35 -0 ports/java/jboss3/files/pkg-deinstall.in (new) 1.1 +46 -0 ports/java/jboss3/files/pkg-install.in (new) 1.2 +0 -7 ports/java/jboss3/files/pkg-message (dead) 1.1 +7 -0 ports/java/jboss3/files/pkg-message.in (new) 1.3 +0 -58 ports/java/jboss3/files/startup.sh (dead) 1.3 +0 -35 ports/java/jboss3/pkg-deinstall (dead) 1.2 +0 -46 ports/java/jboss3/pkg-install (dead) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"