Bug 111151 - ports/lang/stklos: l/bin/stklos-install is a buggy shell script
Summary: ports/lang/stklos: l/bin/stklos-install is a buggy shell script
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-02 20:50 UTC by clemens fischer
Modified: 2007-06-24 16:20 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description clemens fischer 2007-04-02 20:50:03 UTC
it's impossible to install stklos "extensions" due to errors in script:
local/bin/stklos-install.

what i didn't understand is the absence of
local/lib/stklos/0.82/syslog.{so,stk}, which seem to be important for
installing the "htmlprag" extension.

this lib directory just contains: local/lib/stklos/0.82/ldap.so, which
i don't even need.

Fix: /l/bin/stklos-install implies having the current directory in $PATH, and
the Makefile is built using autoconf and wants gmake instead of make:

rcsdiff --unified /l/bin/stklos-install /RCS/STKLOS/stklos-install,v
===================================================================
RCS file: /RCS/STKLOS/stklos-install,v
retrieving revision 1.2


(eval "cd ${BUILDDIR}*";
-     trace "Configuring package ..." && configure &&
-     trace "Make package ..." &&  make &&
-     trace "Installing package ..." && make install)
+     trace "Configuring package ..." && ./configure &&
+     trace "Make package ..." &&  gmake &&
+     trace "Installing package ..." && gmake install)

     if [ $? = 0 -a $opt_keep = 0 ] ;then
        /bin/rm -rf $TMP--pusLJKwk5kpYx9TJo4jkJCXFppRI0i6jVN5LfeW690v9UmGf
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

diff --unified -r1.2 /l/bin/stklos-install
--- /l/bin/stklos-install       2007/04/02 17:16:17     1.2
+++ /l/bin/stklos-install       2007/04/02 17:18:24
@@ -128,9 +128,9 @@
     cat $pkg.stgz | (cd $TMP; tar xvfz -)
How-To-Repeat: 
you could try "stklos-install htmlprag" and watch it fail.  this command
downloads an extension, configures, makes and installs it.

  /tmp/stklos-setup-6509/htmlprag-0.50
  1  # stklos-install -k htmlprag
  **** Installing package htmlprag
  **** Installation takes place in in /tmp/stklos-setup-7573/htmlprag
  x htmlprag-0.50/
  x htmlprag-0.50/.hgtags
  x htmlprag-0.50/COPYING
  x htmlprag-0.50/ChangeLog
  x htmlprag-0.50/Makefile.in
  x htmlprag-0.50/README
  x htmlprag-0.50/adapt.stk
  x htmlprag-0.50/configure
  x htmlprag-0.50/configure.in
  x htmlprag-0.50/doc/
  x htmlprag-0.50/doc/Makefile.in
  x htmlprag-0.50/doc/eg-web-extension.ske
  x htmlprag-0.50/doc/htmlprag-doc-style.css
  x htmlprag-0.50/doc/htmlprag-doc-style.tex
  x htmlprag-0.50/doc/htmlprag-original.html
  x htmlprag-0.50/doc/htmlprag.html
  x htmlprag-0.50/doc/htmlprag.pdf
  x htmlprag-0.50/doc/htmlprag.skb
  x htmlprag-0.50/doc/lib.stk
  x htmlprag-0.50/doc/version.stk.in
  x htmlprag-0.50/examples/
  x htmlprag-0.50/examples/Makefile.in
  x htmlprag-0.50/examples/testhtmlprag.stk
  x htmlprag-0.50/htmlprag.scm
  x htmlprag-0.50/htmlprag.stk
  **** Configuring package ...
  configure: creating ./config.status
  config.status: creating Makefile
  config.status: creating doc/Makefile
  config.status: creating doc/version.stk
  config.status: creating examples/Makefile
  **** Make package ...
  stklos -f adapt htmlprag.scm htmlprag.ss
  ** define-syntax %htmlprag:testeez skipped
  ** define %htmlprag:a2c skipped
  ** define (%htmlprag:append! a b) skipped
  ** define %htmlprag:reverse!ok skipped
  ** define-syntax %htmlprag:error skipped
  ** define (%htmlprag:down s) skipped
  ** define %htmlprag:down!ok skipped
  ** define (%htmlprag:gosc os) skipped
  ** define (%htmlprag:test) skipped
  ** EOF
  stklos-compile -o htmlprag.ostk htmlprag.stk
  Compilation time 406.25
  (cd examples; gmake)
  gmake[1]: Entering directory `/tmp/stklos-setup-7573/htmlprag-0.50/examples'
  stklos-compile -o testhtmlprag testhtmlprag.stk
  testhtmlprag.stk:34: warning: reference to undefined symbol html->sxml-2nf
  Compilation time 7.8125
  gmake[1]: Leaving directory `/tmp/stklos-setup-7573/htmlprag-0.50/examples'
  **** Installing package ...
  (cd examples; gmake)
  gmake[1]: Entering directory `/tmp/stklos-setup-7573/htmlprag-0.50/examples'
  gmake[1]: Nothing to be done for `all'.
  gmake[1]: Leaving directory `/tmp/stklos-setup-7573/htmlprag-0.50/examples'
  (cd doc; make install)
  (cd  ..;  for i in htmlprag.html htmlprag-doc-style.css ; do  stklos-ext-install htmlprag-0.50 doc/$i share/stklos/`stklos-config -v`  0644 ;  done)
  (cd examples; make install)
  stklos-ext-install htmlprag-0.50 syslog.so lib/stklos/`stklos-config -v` 0755
  cp: syslog.so: No such file or directory
  chmod: /usr/local/lib/stklos/0.82/syslog.so: No such file or directory
  stklos-ext-install htmlprag-0.50 syslog.stk lib/stklos/`stklos-config -v` 0755
  cp: syslog.stk: No such file or directory
  chmod: /usr/local/lib/stklos/0.82/syslog.stk: No such file or directory
  **** Problem while compiling package.
  **** Look at /tmp/stklos-setup-7573/htmlprag directory for more information
  **** Package htmlprag is successfully installed.

  /tmp/stklos-setup-6509/htmlprag-0.50
  0  # stklos-install -l
  **** Available extensions:
          htmlprag-0.50
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-04-02 20:50:13 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2007-06-17 23:06:44 UTC
State Changed
From-To: feedback->open

maintainer feedback timeout
Comment 3 Rong-En Fan freebsd_committer freebsd_triage 2007-06-24 16:11:27 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 4 dfilter service freebsd_committer freebsd_triage 2007-06-24 16:11:30 UTC
rafan       2007-06-24 15:11:24 UTC

  FreeBSD ports repository

  Modified files:
    lang/stklos          Makefile 
  Log:
  - The stklos-install assumes current directory is in PATH and make is
    the GNU make. They are not always correct.
  
  PR:             ports/111151
  Submitted by:   clemens fischer <ino-news at spotteswoode.dnsalias.org>
  Approved by:    maintainer timeout (11 weeks)
  
  Revision  Changes    Path
  1.13      +3 -1      ports/lang/stklos/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"