New version of juk can build with libtunepimp 0.5.3 correctly: http://tb.newzilla.org/logs/6.2-FreeBSD/kdemultimedia-juk-3.5.6_1.log http://tb.newzilla.org/logs/5.5-FreeBSD/kdemultimedia-juk-3.5.6_1.log So we can change it's dependence form audio/libtunepimp-old to audio/libtunepimp Besides, attached patch contains a little portlint(1) fix. Port maintainer (kde@FreeBSD.org) is cc'd. Generated with FreeBSD Port Tools 0.77
Responsible Changed From-To: freebsd-ports-bugs->alexbl Over to maintainer
Responsible Changed From-To: alexbl->kde I maintain libtunepimp not kdemultimedia-juk, so pass it to the real maintainers
lofi 2007-04-15 09:35:14 UTC FreeBSD ports repository Modified files: audio/juk Makefile Log: Depend on current libtunepimp. PR: ports/111440 Submitted by: Li-Wen Hsu <lwhsu@FreeBSD.org> Revision Changes Path 1.28 +4 -7 ports/audio/juk/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed, thanks!
On 10 April 2007 18:16, Li-Wen Hsu wrote: > >Number: 111440 > >Category: ports > >Synopsis: [PATCH] audio/kdemultimedia-juk: change LIB_DEPENDS to > > audio/libtunepimp Confidential: no > >Severity: non-critical > >Priority: low > >Responsible: freebsd-ports-bugs > >State: open > >Quarter: > >Keywords: > >Date-Required: > >Class: change-request > >Submitter-Id: current-users > >Arrival-Date: Tue Apr 10 07:20:01 GMT 2007 > >Closed-Date: > >Last-Modified: > >Originator: Li-Wen Hsu > >Release: FreeBSD 6.2-RELEASE i386 > >Organization: > >Environment: > > System: FreeBSD FreeBSD.csie.nctu.edu.tw 6.2-RELEASE FreeBSD 6.2-RELEASE > #12: Sat Jan 20 20:29:28 CST 2007 > > >Description: > > New version of juk can build with libtunepimp 0.5.3 correctly: > > http://tb.newzilla.org/logs/6.2-FreeBSD/kdemultimedia-juk-3.5.6_1.log > http://tb.newzilla.org/logs/5.5-FreeBSD/kdemultimedia-juk-3.5.6_1.log No, this logs shows that builds is NOT detect tunepimp support at all. > So we can change it's dependence form audio/libtunepimp-old to > audio/libtunepimp kdemultimedia-3.5.6 is not tunepimp-0.5-safe. This patch is way to broke libtunepimp support at all. Please revert this update. -- äÍÉÔÒÉÊ á. ðÁÎÏ× áËÁÄÅÍÉÑ üËÏÎÏÍÉËÉ É ðÒÁ×Á èÁÂÁÒÏ×ÓË, òÏÓÓÉÑ
Indeed, this PR/change is completely bogus. That will teach me to blindly trust a patch just because it was submitted by a fellow committer. :( However, before I go ahead and revert this - Dima, does musicbrainz.org support queries made with the old libtunepimp anymore at all, in your experience? I myself had very little luck with it (which is why I switched to amaroK a good while ago).
State Changed From-To: closed->feedback Feedback requested.
Hi, It's really embarrassing we didn't notice === cut me here === checking tunepimp/tp_c.h usability... yes checking tunepimp/tp_c.h presence... yes checking for tunepimp/tp_c.h... yes checking for tp_SetFileNameEncoding in -ltunepimp... yes checking for tp_SetTRMCollisionThreshold in -ltunepimp... no configure: WARNING: Tunepimp 0.5 detected - disabled. === it's over === And Let's talk about libtunepimp-old, the reason we repo it to -old instead '4' is to temporary hold the line for audio/juk, audio/amarok. They have release new versions before last Sep 4 (and someone told me libtunepimp-old can be retired). Anyway, it's always safe to think before we send. Dima, are you insterested in maintain libtunepimp-old? Maybe you can help us keep an eye on it. :-) Best Regards, -- Alan Cheng-Lung Sung - clsung@
On 17 April 2007 09:56, Cheng-Lung Sung wrote: > Hi, > It's really embarrassing we didn't notice > > === cut me here === > checking tunepimp/tp_c.h usability... yes > checking tunepimp/tp_c.h presence... yes > checking for tunepimp/tp_c.h... yes > checking for tp_SetFileNameEncoding in -ltunepimp... yes > checking for tp_SetTRMCollisionThreshold in -ltunepimp... no > configure: WARNING: Tunepimp 0.5 detected - disabled. > === it's over === > > And Let's talk about libtunepimp-old, the reason we > repo it to -old instead '4' is to temporary hold the > line for audio/juk, audio/amarok. They have release > new versions before last Sep 4 (and someone told me > libtunepimp-old can be retired). At present day, libtunepimp-0.4 is requested by all kdemultimedia suite, not only JuK. BTW, AmaroK is already have support for libtunepimp-0.5 > Anyway, it's always safe to think before we send. > > Dima, are you insterested in maintain libtunepimp-old? > Maybe you can help us keep an eye on it. :-) I'll try to port libtunepimp-0.5 support in current kdemultimedia. BTW, many Linux distros stay with libtunepimp-0.4... -- äÍÉÔÒÉÊ á. ðÁÎÏ× áËÁÄÅÍÉÑ üËÏÎÏÍÉËÉ É ðÒÁ×Á èÁÂÁÒÏ×ÓË, òÏÓÓÉÑ
On Tue, Apr 17, 2007 at 11:00:55AM +1100, Dima Panov wrote: > On 17 April 2007 09:56, Cheng-Lung Sung wrote: > > Hi, > > It's really embarrassing we didn't notice > > > > === cut me here === > > checking tunepimp/tp_c.h usability... yes > > checking tunepimp/tp_c.h presence... yes > > checking for tunepimp/tp_c.h... yes > > checking for tp_SetFileNameEncoding in -ltunepimp... yes > > checking for tp_SetTRMCollisionThreshold in -ltunepimp... no > > configure: WARNING: Tunepimp 0.5 detected - disabled. > > === it's over === > > > > And Let's talk about libtunepimp-old, the reason we > > repo it to -old instead '4' is to temporary hold the > > line for audio/juk, audio/amarok. They have release > > new versions before last Sep 4 (and someone told me > > libtunepimp-old can be retired). > > At present day, libtunepimp-0.4 is requested by all kdemultimedia suite, > not only JuK. > BTW, AmaroK is already have support for libtunepimp-0.5 > > > Anyway, it's always safe to think before we send. > > > > Dima, are you insterested in maintain libtunepimp-old? > > Maybe you can help us keep an eye on it. :-) > > I'll try to port libtunepimp-0.5 support in current kdemultimedia. > > BTW, many Linux distros stay with libtunepimp-0.4... I'm not using kde. So thanks. :) -- Alan Cheng-Lung Sung - clsung@
On 17 April 2007 11:11, Cheng-Lung Sung wrote: > > > > > Anyway, it's always safe to think before we send. > > > > > > Dima, are you insterested in maintain libtunepimp-old? > > > Maybe you can help us keep an eye on it. :-) > > > > I'll try to port libtunepimp-0.5 support in current kdemultimedia. > > > > BTW, many Linux distros stay with libtunepimp-0.4... > > I'm not using kde. So thanks. :) OK, I take maintainersip for libtunepimp-old. Using KDE as regular desktop environment is good practice for me and neigborhood :) Hope, upcoming releases of KDE will have support for new library... -- äÍÉÔÒÉÊ á. ðÁÎÏ× áËÁÄÅÍÉÑ üËÏÎÏÍÉËÉ É ðÒÁ×Á èÁÂÁÒÏ×ÓË, òÏÓÓÉÑ
On Tuesday, 17. April 2007, Dima Panov wrote: > On 17 April 2007 09:56, Cheng-Lung Sung wrote: > > Hi, > > It's really embarrassing we didn't notice > > > > === cut me here === > > checking tunepimp/tp_c.h usability... yes > > checking tunepimp/tp_c.h presence... yes > > checking for tunepimp/tp_c.h... yes > > checking for tp_SetFileNameEncoding in -ltunepimp... yes > > checking for tp_SetTRMCollisionThreshold in -ltunepimp... no > > configure: WARNING: Tunepimp 0.5 detected - disabled. > > === it's over === > > > > And Let's talk about libtunepimp-old, the reason we > > repo it to -old instead '4' is to temporary hold the > > line for audio/juk, audio/amarok. They have release > > new versions before last Sep 4 (and someone told me > > libtunepimp-old can be retired). > > At present day, libtunepimp-0.4 is requested by all kdemultimedia suite, > not only JuK. It's only used by juk. All programs distributed in kdemultimedia just share a common configure script.
State Changed From-To: feedback->closed Close obsolete PR.