Bug 111795 - audio/musicpd: multiple hidden dependencies
Summary: audio/musicpd: multiple hidden dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rong-En Fan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-17 23:20 UTC by Dmitry Marakasov
Modified: 2007-06-22 07:50 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov 2007-04-17 23:20:13 UTC
audio/musicpd has multiple hidden dependencies on some libraries:

% cat /var/db/ports/musicpd/options 
# This file is auto-generated by 'make config'.
# No user-servicable parts inside!
# Options for musicpd-0.12.1_1
_OPTIONS_READ=musicpd-0.12.1_1
WITH_FLAC=true
WITH_VORBIS=true
WITH_WAV=true
WITHOUT_AAC=true
WITHOUT_MUSEPACK=true
WITH_MOD=true
WITH_ICONV=true
WITH_ID3TAG=true
WITHOUT_IPV6=true
% pkg_info -r musicpd-0.12.1_1
Information for musicpd-0.12.1_1:

Depends on:
Dependency: pkg-config-0.21
Dependency: libogg-1.1.3,3
Dependency: libvorbis-1.1.2,3
Dependency: libmikmod-3.1.11_2
Dependency: libmad-0.15.1b_2
Dependency: libiconv-1.9.2_2
Dependency: libaudiofile-0.2.6
Dependency: flac-1.1.2_1
% ldd /usr/local/bin/mpd
/usr/local/bin/mpd:
        libshout.so.5 => /usr/local/lib/libshout.so.5 (0x2809e000)
        libtheora.so.2 => /usr/local/lib/libtheora.so.2 (0x280ac000)
        libspeex.so.1 => /usr/local/lib/libspeex.so.1 (0x280dd000)
        libpthread.so.2 => /lib/libpthread.so.2 (0x280fd000)
        libiconv.so.3 => /usr/local/lib/libiconv.so.3 (0x28124000)
        libid3tag.so.0 => /usr/local/lib/libid3tag.so.0 (0x28212000)
        libz.so.3 => /lib/libz.so.3 (0x28225000)
        libmad.so.2 => /usr/local/lib/libmad.so.2 (0x28235000)
        libvorbisfile.so.4 => /usr/local/lib/libvorbisfile.so.4 (0x2824b000)
        libvorbisenc.so.2 => /usr/local/lib/libvorbisenc.so.2 (0x28252000)
        libvorbis.so.3 => /usr/local/lib/libvorbis.so.3 (0x28350000)
        libOggFLAC.so.3 => /usr/local/lib/libOggFLAC.so.3 (0x28377000)
        libogg.so.5 => /usr/local/lib/libogg.so.5 (0x28388000)
        libFLAC.so.7 => /usr/local/lib/libFLAC.so.7 (0x2838d000)
        libaudiofile.so.0 => /usr/local/lib/libaudiofile.so.0 (0x283bc000)
        libm.so.4 => /lib/libm.so.4 (0x283e3000)
        libmikmod.so.2 => /usr/local/lib/libmikmod.so.2 (0x283f9000)
        libc.so.6 => /lib/libc.so.6 (0x2843b000)
        libgcc_s.so.1 => /usr/local/lib/gcc-4.0.4/libgcc_s.so.1 (0x2851d000)

There are at least those hidden dependencies:

audio/libshout2 (libshout.so.5 and thus libtheora.so.2, libspeex.so.1)
lang/gcc40 (libgcc_s.so.1) (wtf?!)
audio/libid3tag (libid3tag.so.0)

Fix: 

* OPTION should be added for libshout2 (and corresponding --without should be added to CONFIGURE_ARGS when it's off)
* LIB_DEPEND should be appended with libid3tag when corresponding option is on
* dunno how to deal with libgcc_s.so.1

sorry, no time to make a patch atm
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-04-17 23:20:22 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Mark Daniel Reidel 2007-04-18 00:24:22 UTC
Hi there!
The port just got updated and fixes all addressed things except the gcc
which I have _never_ heard of. I compiled it with stock GCC3 on 6-STABLE
and it doesn't pull in or use GCC4.

	- Mark
Comment 3 Dmitry Marakasov 2007-04-18 05:14:19 UTC
* Mark Daniel Reidel (ports@mark.reidel.info) wrote:
>  The port just got updated and fixes all addressed things except the gcc
>  which I have _never_ heard of. I compiled it with stock GCC3 on 6-STABLE
>  and it doesn't pull in or use GCC4.
It still has no dependency on audio/libid3tag, though it seem to no
longer link against libshout.

It doesn't pull or use gcc4 (I'm compiling it with stock gcc3 as
well), though it somehow links against this libgcc_s.so.1 when
lang/gcc40 is installed. Would you like full build log?

-- 
Best regards,
  Dmitry Marakasov               mailto:amdmi3@amdmi3.ru
Comment 4 Rong-En Fan freebsd_committer freebsd_triage 2007-06-21 07:52:43 UTC
Responsible Changed
From-To: freebsd-ports-bugs->rafan

I'll take it.
Comment 5 dfilter service freebsd_committer freebsd_triage 2007-06-22 07:45:43 UTC
rafan       2007-06-22 06:45:35 UTC

  FreeBSD ports repository

  Modified files:
    audio/musicpd        Makefile 
  Log:
  - Add missing dependency when ID3TAG knob is on
  
  PR:           ports/111795
  Submitted by: Dmitry Marakasov <amdmi3 at amdmi3.ru>
  Approved by:  Mark Daniel Reidel <ports at mark.reidel.info> (maintainer, implicit)
  
  Revision  Changes    Path
  1.25      +1 -0      ports/audio/musicpd/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Rong-En Fan freebsd_committer freebsd_triage 2007-06-22 07:45:46 UTC
State Changed
From-To: feedback->closed

missing dependency libid3tag is added.