Update to port www/shttpd from version 1.27 to version 1.37 Fix: Patch attached with submission follows:
State Changed From-To: open->feedback Awaiting maintainers feedback
Responsible Changed From-To: freebsd-ports-bugs->araujo I'll take it.
On Mon, 30 Apr 2007 14:09:36 -0300 Marcelo Araujo <araujobsdport@gmail.com> mentioned: > Hey dear! > > I take PR and build in tinderbox. > I stay waiting to approve! > > PR: ports/112272 > Log: http://people.freebsd.org/~araujo/logs/shttpd-1.37.log do-build: - ${CC} ${CFLAGS} -DCONFIG=\"${PREFIX}/etc/shttpd.conf\" \ - ${WRKSRC}/shttpd.c -o ${WRKSRC}/shttpd + #${CC} ${CFLAGS} -DCONFIG=\"${PREFIX}/etc/shttpd.conf\" \ + # ${WRKSRC}/shttpd.c -o ${WRKSRC}/shttpd + cd ${WRKSRC}/src && make unix CFLAGS="${CFLAGS}" 1) Why leave comments in Makefile and just not drop these lines? 2) We should not execute 'make' directly, use ${MAKE} alias instead. Also we generally want the make enviropment to be set, so use the following instead of 'make': cd ${WRKSRC}/src && ${SETENV} ${MAKE_ENV} ${MAKE} unix CFLAGS="${CFLAGS}" -- Stanislav Sedov ST4096-RIPE
The patch looks fine to me, thank you. sergey On Mon, 30 Apr 2007 14:20:07 UT, Edwin Groothuis <edwin@freebsd.org> wrote: > Maintainer of www/shttpd, > > Please note that PR ports/112272 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/112272 > > -- > Edwin Groothuis > edwin@FreeBSD.org >
This is a multi-part message in MIME format.
not sure about "USE_AUTOTOOLS = yes", since autotools are not used by package at all. The rest looks fine. sergey On 06/05/07, Marcelo Araujo <araujobsdport@gmail.com> wrote: > Hi dear maintainer! > > I did little modification in Makefile! > Please, look the modifications and give me your approval! > > Thank you for uphold this package! > > Best Regards! > > -- > Marcelo Araujo > araujo@FreeBSD.org > http://www.FreeBSD.org > > >
Sergey Lyubka wrote: > not sure about "USE_AUTOTOOLS = yes", > since autotools are not used by package at all. > The rest looks fine. > > sergey > > On 06/05/07, Marcelo Araujo <araujobsdport@gmail.com> wrote: >> Hi dear maintainer! >> >> I did little modification in Makefile! >> Please, look the modifications and give me your approval! >> >> Thank you for uphold this package! >> >> Best Regards! >> >> -- >> Marcelo Araujo >> araujo@FreeBSD.org >> http://www.FreeBSD.org >> >> >> > You was correct, because the package don't use configure or another tool. Thank you for your work on the FreeBSD. Best Regards. -- Marcelo Araujo araujo@FreeBSD.org http://www.FreeBSD.org
araujo 2007-05-26 15:22:26 UTC FreeBSD ports repository Modified files: www/shttpd Makefile distinfo Log: - Update to 1.37. PR: ports/112272 Submitted by: Patrick Powell <papowell@astart.com> Approved by: stas (mentor) Revision Changes Path 1.16 +5 -7 ports/www/shttpd/Makefile 1.17 +3 -3 ports/www/shttpd/distinfo _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed. Thanks!