Bug 112347 - [PATCH] editors/vim re-enable WITH_TCL
Summary: [PATCH] editors/vim re-enable WITH_TCL
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: David E. O'Brien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-02 11:40 UTC by Martin Matuska
Modified: 2010-07-28 20:32 UTC (History)
0 users

See Also:


Attachments
file.diff (2.79 KB, patch)
2007-05-02 11:40 UTC, Martin Matuska
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Matuska freebsd_committer freebsd_triage 2007-05-02 11:40:08 UTC
- fixed TCL_DEFS processing in patch-configure
- re-enabled Tcl support (using new bsd.tcl.mk)
- supports Tcl 80, 82, 83, 84, 85 (WITH_TCL_VER=8x or VIM_WITH_TCL_VER=8x)
- no support for threaded Tcl yet (because of the way how vim's configure 
searches for Tcl, this needs more modifications)

Tinderbox output for 5.5-R, 6.2-R and 7-C i386 and amd64:

http://i386.vx.sk/logs/6.2-FreeBSD-i386/vim-7.0.224_1.log
http://i386.vx.sk/logs/7-FreeBSD-i386/vim-7.0.224_1.log
http://i386.vx.sk/logs/5.5-FreeBSD-i386/vim-7.0.224_1.log

http://amd64.vx.sk/logs/6.2-FreeBSD-amd64/vim-7.0.224_1.log
http://amd64.vx.sk/logs/7-FreeBSD-amd64/vim-7.0.224_1.log
http://amd64.vx.sk/logs/5.5-FreeBSD-amd64/vim-7.0.224_1.log

If commited, please close these related PR's:
ports/103844
ports/99678
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-05-02 11:40:16 UTC
Responsible Changed
From-To: freebsd-ports-bugs->obrien

Over to maintainer
Comment 2 mi+metlife 2007-06-13 16:04:41 UTC
Hi, Martin, thanks for the patch. Does it have to explicitly disable 
threaded Tcl, though?

    -mi

P.S. David, you don't seem to be Tcl-enthusiast, would you mind if I 
commit this? I plan to add OPTIONS too, to expose the knobs properly...
Comment 3 mi+metlife 2007-06-13 21:43:29 UTC
Please, take a look at the update posted on my:

    http://aldan.algebra.com/~mi/vim-7.0.243.diff

Based on Martin's work, this patch unifies handling of the three 
interpreters (Ruby, Python, and Tcl), which can not be set via options 
due to the unfortunate chicken-and-egg problem with the current 
implementation of bsd.ports.pre/post.mk mechanism. What can be set via 
OPTIONS, is so set.

I also upped the version to the most current 243 patch-level, although 
the last two patches (242 and 243) don't apply on Unix.

Please, test... Thanks!

    -mi
Comment 4 dfilter service freebsd_committer freebsd_triage 2007-12-19 16:30:34 UTC
obrien      2007-12-19 16:30:28 UTC

  FreeBSD ports repository

  Modified files:
    editors/vim          Makefile 
    editors/vim/files    patch-configure 
  Log:
  Re-enable WITH_TCL.
  + fixed TCL_DEFS processing in patch-configure
  + re-enabled Tcl support (using new bsd.tcl.mk)
  + supports Tcl 80, 82, 83, 84, 85 (WITH_TCL_VER=8x or VIM_WITH_TCL_VER=8x)
  + no support for threaded Tcl yet (because of the way how vim's configure
    searches for Tcl, this needs more modifications)
  
  PR:             112347
  Submitted by:   mm
  
  Revision  Changes    Path
  1.317     +7 -8      ports/editors/vim/Makefile
  1.4       +1 -1      ports/editors/vim/files/patch-configure
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 David E. O'Brien freebsd_committer freebsd_triage 2007-12-19 16:30:35 UTC
State Changed
From-To: open->patched

Mikhail T. has some additional good bits I want to integrate in.
Comment 6 Martin Matuska freebsd_committer freebsd_triage 2010-07-28 20:32:03 UTC
State Changed
From-To: patched->closed

This has already been resolved (myself = submitter)