New version... added functionality, bugs squashed, etc. Fix: Apply patch. Patch attached with submission follows:
Class Changed From-To: maintainer-update->change-request Fix category (submitter is not maintainer)
State Changed From-To: open->feedback Awaiting maintainers feedback
Edwin Groothuis wrote: > Maintainer of comms/syncterm, > > Please note that PR ports/113072 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/113072 > > Approved (I submitted it :-)
Responsible Changed From-To: freebsd-ports-bugs->araujo I'll take it.
Did I miss a request for feedback?
Hey Stephen, Please, you should check the problem on this port. I wait your fix or another suggestion for this short problem. http://200.247.114.5/tb/errors/6.2-RELEASE/syncterm-0.9.20070527_1.log Best Regards. -- Marcelo Araujo (__) araujo@FreeBSD.org \\\'',) http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)
Marcelo Araujo wrote: > Hey Stephen, > > Please, you should check the problem on this port. > I wait your fix or another suggestion for this short problem. > Patch submitted upstream. Please close this PR as I will resubmit a new one after it's cleaned up.
Stephen Hurd wrote: > The following reply was made to PR ports/113072; it has been noted by GNATS. > > From: Stephen Hurd <shurd@sasktel.net> > To: araujo@FreeBSD.org > Cc: bug-followup@FreeBSD.org > Subject: Re: ports/113072: [Maintainer-Update] comms/syncterm to latest version > Date: Mon, 18 Jun 2007 02:40:01 -0700 > > Marcelo Araujo wrote: > > Hey Stephen, > > > > Please, you should check the problem on this port. > > I wait your fix or another suggestion for this short problem. > > > > Patch submitted upstream. Please close this PR as I will resubmit a new > one after it's cleaned up. > > Hey Stephen, You need help to fix this Port? I can help you! Not is necessary to open a new PR for to update this Port, use the same PR for this. Best Regards! -- Marcelo Araujo (__) araujo@FreeBSD.org \\\'',) http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)
Marcelo Araujo wrote: > Hey Stephen, > > You need help to fix this Port? I can help you! > Not is necessary to open a new PR for to update this Port, use the same > PR for this. > Nah, the makefile needed to be fixed. It's fixed in CVS now, so the next working archive will be fixed up. Should be done by this weekend. I'll use the same PR then.
Updated patch.
araujo 2007-07-15 15:59:54 UTC FreeBSD ports repository Modified files: comms/syncterm Makefile distinfo Log: - Update to 0.9.20070704. PR: ports/113072 Submitted by: Stephen Hurd <shurd@sasktel.net> (maintainer) Approved by: stas (mentor) Revision Changes Path 1.4 +12 -8 ports/comms/syncterm/Makefile 1.2 +3 -3 ports/comms/syncterm/distinfo _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed, with minor changes. Thanks!
Hrm... the minor changes seem to be to not install the manpage, icon or the .desktop file... is there a reason the install target in the included makefile can't be used?
Stephen Hurd wrote: > The following reply was made to PR ports/113072; it has been noted by GNATS. > > Hrm... the minor changes seem to be to not install the manpage, icon or > the .desktop file... is there a reason the install target in the > included makefile can't be used? > > Hi Developer! Sorry, inside your patch not exist manpage to install. Also to install ICONS and DESKTOP files is necessary to check if exist any WINDOW MANAGER installed on your system. Well, I can re-open your PR and wait your patch! I'm waiting your feedback about it. Best Regards. -- Marcelo Araujo (__) araujo@FreeBSD.org \\\'',) http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)
Marcelo Araujo wrote: > Hi Developer! > Sorry, inside your patch not exist manpage to install. > Hrm, I'll definately want to fix that! > Also to install ICONS and DESKTOP files is necessary to check if exist > any WINDOW MANAGER installed on your system. > I don't understand the reasoning for this one... is there a policy document somewhere regarding it?
On Mon, 16 Jul 2007 23:28:15 -0700 Stephen Hurd <shurd@sasktel.net> mentioned: > > I don't understand the reasoning for this one... is there a policy > document somewhere regarding it? > > I believe Marcelo mean, that installing icon files without any WM doesn't make much sense. However, it really makes sense, since if WM will be installed later, icons will work too. The problem with icons in the first version of patch was you forgotten to @dirrmtry all icon-related directories, such as share/icons/hicolor/64x64, share/icons/hicolor and share/icons. -- Stanislav Sedov ST4096-RIPE
State Changed From-To: closed->open Maintainer not approved my commit!
Stanislav Sedov wrote: > I believe Marcelo mean, that installing icon files without any WM > doesn't make much sense. However, it really makes sense, since if WM > will be installed later, icons will work too. The problem with icons in > the first version of patch was you forgotten to @dirrmtry all > icon-related directories, such as share/icons/hicolor/64x64, > share/icons/hicolor and share/icons. > > Hi guys, Sorry for my mistake, but, I believe I fix the mistake and you pardons me! I'm waiting [1]mentor approval. [1] - Thanks a lot. The patch: http://people.freebsd.org/~araujo/logs/syncterm.diff Best Regards! -- Marcelo Araujo (__) araujo@FreeBSD.org \\\'',) http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)
On Tue, 17 Jul 2007 08:02:30 -0300 Marcelo Araujo <araujobsdport@gmail.com> mentioned: > Stanislav Sedov wrote: > > I believe Marcelo mean, that installing icon files without any WM > > doesn't make much sense. However, it really makes sense, since if WM > > will be installed later, icons will work too. The problem with icons in > > the first version of patch was you forgotten to @dirrmtry all > > icon-related directories, such as share/icons/hicolor/64x64, > > share/icons/hicolor and share/icons. > > > > > Hi guys, > Sorry for my mistake, but, I believe I fix the mistake and you pardons me! > I'm waiting [1]mentor approval. > > [1] - Thanks a lot. > > The patch: http://people.freebsd.org/~araujo/logs/syncterm.diff > > + ${MKDIR} ${PREFIX}/share/applications/ Why not use ${MKDIR} ${DESKTOPDIR}/ ? -- Stanislav Sedov ST4096-RIPE
Stanislav Sedov wrote: > On Tue, 17 Jul 2007 08:02:30 -0300 > Marcelo Araujo <araujobsdport@gmail.com> mentioned: > > + ${MKDIR} ${PREFIX}/share/applications/ > > > Why not use ${MKDIR} ${DESKTOPDIR}/ ? > > Fixed! -- Marcelo Araujo (__) araujo@FreeBSD.org \\\'',) http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)
On Tue, 17 Jul 2007 09:14:23 -0300 Marcelo Araujo <araujobsdport@gmail.com> mentioned: > Stanislav Sedov wrote: > > On Tue, 17 Jul 2007 08:02:30 -0300 > > Marcelo Araujo <araujobsdport@gmail.com> mentioned: > > > > + ${MKDIR} ${PREFIX}/share/applications/ > > > > > > Why not use ${MKDIR} ${DESKTOPDIR}/ ? > > > > > Fixed! > Approved. -- Stanislav Sedov ST4096-RIPE
State Changed From-To: open->closed Committed, with minor changes. Thanks!
>>> >>> + ${MKDIR} ${PREFIX}/share/applications/ >>> >>> >>> Why not use ${MKDIR} ${DESKTOPDIR}/ ? >>> >>> >>> >> Fixed! >> >> > > Approved. > Hrm, that brings up an interesting question... If DESKTOPDIR is overridden, the pkg-plist is then wrong. However, since DESKTOPDIR isn't specified relative to PREFIX, should you use a PLIST_SUB to put the absolute path in the pkg-plist? Or is that "wrong" too? In the Makefile: PLIST_SUB= DESKTOPDIR=${DESKTOPDIR) In the plist: %%DESKTOPDIR%%/syncterm.desktop @dirrmtry %%DESKTOPDIR%%
On Tue, 17 Jul 2007 09:52:43 -0700 Stephen Hurd <shurd@sasktel.net> mentioned: > >>> > >>> + ${MKDIR} ${PREFIX}/share/applications/ > >>> > >>> > >>> Why not use ${MKDIR} ${DESKTOPDIR}/ ? > >>> > >>> > >>> > >> Fixed! > >> > >> > > > > Approved. > > > > Hrm, that brings up an interesting question... > If DESKTOPDIR is overridden, the pkg-plist is then wrong. However, > since DESKTOPDIR isn't specified relative to PREFIX, should you use a > PLIST_SUB to put the absolute path in the pkg-plist? Or is that "wrong" > too? > > In the Makefile: > PLIST_SUB= DESKTOPDIR=${DESKTOPDIR) > > In the plist: > %%DESKTOPDIR%%/syncterm.desktop > @dirrmtry %%DESKTOPDIR%% > > > I think the following will do the trick: PLIST_SUB+= DESKTOPDIR="${_DESKTOPDIR_REL}" -- Stanislav Sedov ST4096-RIPE
Stephen Hurd wrote: > Hrm, that brings up an interesting question... > If DESKTOPDIR is overridden, the pkg-plist is then wrong. However, > since DESKTOPDIR isn't specified relative to PREFIX, should you use a > PLIST_SUB to put the absolute path in the pkg-plist? Or is that > "wrong" too? > > In the Makefile: > PLIST_SUB= DESKTOPDIR=${DESKTOPDIR) > > In the plist: > %%DESKTOPDIR%%/syncterm.desktop > @dirrmtry %%DESKTOPDIR%% > Very good point, Well, I believe just that must be wrong because it would add again ${PREFIX} in pkg-plist, the result would be ${PREFIX}${PREFIX}. The PLIST_SUB is a good option to be used when you have many files to set control parameters. In the case that you wanna put this set into MAKEFILE, we must put it in such a way: DESKTOPDIR_BLA= ${PREFIX}/share/applications/ DESKTOPDIR= ${DESKTOPDIR_BLA:S|^${PREFIX}/||} PLIST_SUB= DESKTOPDIR="${DESKTOPDIR}" You should look more information about this at: http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#PLIST-SUB Best Regards. -- Marcelo Araujo (__) araujo@FreeBSD.org \\\'',) http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)
This is a multi-part message in MIME format.
Stephen Hurd wrote: > At this point though, I'll approve any changes. :-) > > I think this should be examined by the ports guys however. > Sorry for my delay, I need to point two situations for the maintainer. 1 - Today you see many problems with the actual PORT, I don't understand why you did not right in first time. 2 - I believe, is correct a fix it on CVS, because is just wrong consistency. My suggestion, we fix with the last PATCH or we come back for last version on CVS. Best Regards. -- Marcelo Araujo (__) araujo@FreeBSD.org \\\'',) http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)
Marcelo Araujo wrote: > Sorry for my delay, > I need to point two situations for the maintainer. > > 1 - Today you see many problems with the actual PORT, I don't understand > why you did not right in first time. > I'm not sure what you're referring to here... the original was missing the MAN1 and MANCOMPRESSED lines, but the do-install target was not mine and the DESKTOPDIR variable usage wasn't mine either. I missed the man page stuff (which I need to correctly) but the do-install target was new and was missing some pieces. I pointed this out which brought up the point that DESKTOPDIR is the correct place to put desktop files (this isn't documented in the porters handbook and portlint doesn't mention it either). The problems with DESKTOPDIR aren't problems with the actual port at all, but problems with the port system itself. I can understand being frustrated about this, but please only blame my problem (the man pages being unspecifed) on me. Not the other problems. I am not aware of any other problems with the actual port as submitted as none have been brought up. > 2 - I believe, is correct a fix it on CVS, because is just wrong > consistency. > I'm fine with what is in CVS. > My suggestion, we fix with the last PATCH or we come back for last > version on CVS. > I can do up another version which specifies MAN1 and MANCOMPRESSED and removes the do-install target if you prefer. Or we can leave it as is in CVS until the next update.
AHA! The root problem of everything is a missing file in the archive! Everything becomes clear to me now... do-install was needed since the install target failed due to the dependencies not being satisfied. Will be uploaded a new archive soonest and updating the port. Apologies for that last email, my fuse was a little short today *blush*
New port attached.
> > Apologies for that last email, my fuse was a little short today *blush* > Hi Stephen, No problem, I'm happy because we found the solution for this PORT and we talked a lot about the good practices for implementing on this PORT. Thank's for your help! -- Marcelo Araujo (__) araujo@FreeBSD.org \\\'',) http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)
Stephen Hurd wrote: > New port attached. Hei Stephen, Please, Look at: http://200.247.114.5/tb/errors/6.2-RELEASE/syncterm-0.9.20070722.log We has a problem with this PATCH, you can check it and send to me again. You can test your PORT with ports-mgmt/porttools Best Regards. -- Marcelo Araujo (__) araujo@FreeBSD.org \\\'',) http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)
On Mon, 23 Jul 2007 08:16:22 -0300 Marcelo Araujo <araujobsdport@gmail.com> mentioned: > Stephen Hurd wrote: > > New port attached. > Hei Stephen, > > Please, > Look at: > http://200.247.114.5/tb/errors/6.2-RELEASE/syncterm-0.9.20070722.log > > We has a problem with this PATCH, you can check it and send to me again. > You can test your PORT with ports-mgmt/porttools > > Yup, it seems that manpage was installed in the incorrect location. -- Stanislav Sedov ST4096-RIPE
Marcelo Araujo wrote: > Stephen Hurd wrote: > >> New port attached. >> > Hei Stephen, > > Please, > Look at: > http://200.247.114.5/tb/errors/6.2-RELEASE/syncterm-0.9.20070722.log > > We has a problem with this PATCH, you can check it and send to me again. > You can test your PORT with ports-mgmt/porttools > > > Best Regards. > I've attached a patch file which can go into the files directrory. However, this has also gone into the SyncTERM CVS repository, so we could just wait for tomorrows archive and use that (since this patch will need to be deleted on the next update anyways) Your call.
> I've attached a patch file which can go into the files directrory. > However, this has also gone into the SyncTERM CVS repository, so we > could just wait for tomorrows archive and use that (since this patch > will need to be deleted on the next update anyways) > > Your call. Ok, so I hadn't acually attached it... Here it is...
Stephen Hurd wrote: > > Ok, so I hadn't acually attached it... > > Here it is... Hi Stephen, Is the final PATCH, please look at: http://people.freebsd.org/~araujo/logs/syncterm.diff I have your approval? Best Regards. -- Marcelo Araujo (__) araujo@FreeBSD.org \\\'',) http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)
Marcelo Araujo wrote: > Is the final PATCH, please look at: > http://people.freebsd.org/~araujo/logs/syncterm.diff > I have your approval? > > YES! Hooray!