Bug 113215 - [maintainer-update] net-mgmt/nagios-plugins: Several binaries not installed if check_mysql enabled
Summary: [maintainer-update] net-mgmt/nagios-plugins: Several binaries not installed i...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Matuska
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-01 11:50 UTC by Jarrod Sayers
Modified: 2007-06-09 09:32 UTC (History)
0 users

See Also:


Attachments
net-mgmt-nagios-plugins-1.4.8-mysql.diff (1.38 KB, patch)
2007-06-01 11:50 UTC, Jarrod Sayers
no flags Details | Diff
nagios-plugins-1.4.9,1.diff (1.34 KB, patch)
2007-06-04 14:06 UTC, Martin Matuska
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jarrod Sayers 2007-06-01 11:50:01 UTC
A typo in the releases configure.in script accidentally causes the check_ldap,
check_ldaps, check_pgsql and check_radius binaries to be ignored when support
for MySQL is enabled (to provide check_mysql and check_mysql_query).  When
MySQL support is not enabled, all selected binaries are installed without any
worries.

Thanks go to Jay Chandler who pointed out that check_ldap wasn't being compiled
and quizzed me as to whether this was known or not.

Fix: Downloadable diff from:
http://www.netleader.com.au/~jarrod/FreeBSD/net-mgmt-nagios-plugins-1.4.8-mysql.diff
Comment 1 Martin Matuska freebsd_committer freebsd_triage 2007-06-02 22:54:48 UTC
Responsible Changed
From-To: freebsd-ports-bugs->mm

I'll take it.
Comment 2 Martin Matuska freebsd_committer freebsd_triage 2007-06-03 00:09:23 UTC
More information:
fixed on SourceForge but not yet released
http://nagiosplug.cvs.sourceforge.net/nagiosplug/nagiosplug/configure.in?r1=1.213&r2=1.214
Comment 3 Martin Matuska freebsd_committer freebsd_triage 2007-06-04 14:06:30 UTC
Today's 1.4.9 release fixes this problem (and other ones, too).
Jarrod, please approve this patch, thanks.
Comment 4 Martin Matuska freebsd_committer freebsd_triage 2007-06-04 14:35:01 UTC
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
 
I missed to add the pkg-plist changes, here is a revised patch that
adds a WITHOUT_NLS knob:
http://mm.vx.sk/diffs/nagios-plugins-1.4.9,1.diff

Updated i386 and amd64 buildlogs for 5.5, 6.2, 7:
http://mm.vx.sk

Maintainer please approve or submit own changes.
Thanks.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (MingW32)
Comment: GnuPT 2.7
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
 
iD8DBQFGZBUEp2uLA0JhsNERAmVjAJ4u1AQa5PlXGcSu0rYkEBbIY7B0UQCgiIII
zvNESrDjUGqFtnCZue65rpU=
=DO/9
-----END PGP SIGNATURE-----
Comment 5 Martin Matuska freebsd_committer freebsd_triage 2007-06-04 15:59:23 UTC
State Changed
From-To: open->feedback

Awaiting maintainer's feedback.
Comment 6 Jarrod Sayers 2007-06-09 03:47:41 UTC
On 04/06/2007, at 11:05 PM, Martin Matuska wrote:
> I missed to add the pkg-plist changes, here is a revised patch that
> adds a WITHOUT_NLS knob:
> http://mm.vx.sk/diffs/nagios-plugins-1.4.9,1.diff
>
> Updated i386 and amd64 buildlogs for 5.5, 6.2, 7:
> http://mm.vx.sk
>
> Maintainer please approve or submit own changes.
> Thanks.

Changes approved, thanks for that.  Below is the updated patch to use:
http://www.netleader.com.au/~jarrod/FreeBSD/net-mgmt-nagios- 
plugins-1.4.9.diff

Jarrod.
Comment 7 dfilter service freebsd_committer freebsd_triage 2007-06-09 09:21:45 UTC
mm          2007-06-09 08:21:38 UTC

  FreeBSD ports repository

  Modified files:
    net-mgmt/nagios-plugins Makefile distinfo pkg-plist 
  Log:
  - update to 1.4.9
  - added WITHOUT_NLS knob
  
  PR:             ports/113215
  Reviewed by:    maintainer
  Approved by:    garga (mentor)
  
  Revision  Changes    Path
  1.61      +9 -2      ports/net-mgmt/nagios-plugins/Makefile
  1.24      +3 -3      ports/net-mgmt/nagios-plugins/distinfo
  1.20      +3 -0      ports/net-mgmt/nagios-plugins/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 8 Martin Matuska freebsd_committer freebsd_triage 2007-06-09 09:31:43 UTC
State Changed
From-To: feedback->closed

Commited with changes, thanks!