New port. See subject.
Responsible Changed From-To: freebsd-ports-bugs->vd I will take it.
Vasil, Thread-specific code isn't ported. So some tests are likely top break. I will double check and makme corrections that you asked for. Yuri Quoting Vasil Dimov <vd@FreeBSD.org>: > Yuri, > > Here it a shar which fixes some obvious things in your original > submission. > > Unfortunately when I run ``make check'' I get: > > ... > ====================================== > 8 of 19 tests failed > Please report to opensource@google.com > ====================================== > ... > > are you sure that this is not caused by the patches in files/ > subdirectory? > > Also it would be best if you can wrap FreeBSD specific stuff around > #ifdef __FreeBSD__ ... #elese ... #endif > so that the patch can be applied upstream. > > It is unappropriate to add this port if there are self-tests which fail. > > -- > Vasil Dimov > moc.elcaro@vomid.lisav Software Developer @ Oracle/Innobase Oy > gro.DSBeerF@dv Committer @ FreeBSD.org > gro.d5v@dv Home @ Sofia, Bulgaria > --
State Changed From-To: open->feedback It is unappropriate to add this port if there are self-tests which fail. If this is known for sure to be harmless, then the failing tests should be removed, so that `make test' succeeds.
Vasil, Google fixed all FreeBSD compatibility issues itself. Also only 1 of 18 test cases fail now, hopefully they will fix it as well. Please find attached a new perftools shar archive and check it into CVS. Thanks, Yuri Vasil Dimov wrote: > Yuri, > > Here it a shar which fixes some obvious things in your original > submission. > > Unfortunately when I run ``make check'' I get: > > ... > ====================================== > 8 of 19 tests failed > Please report to opensource@google.com > ====================================== > ... > > are you sure that this is not caused by the patches in files/ > subdirectory? > > Also it would be best if you can wrap FreeBSD specific stuff around > #ifdef __FreeBSD__ ... #elese ... #endif > so that the patch can be applied upstream. > > It is unappropriate to add this port if there are self-tests which fail. > >
State Changed From-To: feedback->closed No feedback received for 2+ months.
State Changed From-To: closed->open Feedback received, I will take a look ASAP. Thanks!
vd 2007-10-11 15:36:31 UTC FreeBSD ports repository Modified files: devel Makefile Added files: devel/google-perftools Makefile distinfo pkg-descr pkg-plist Log: Add new port devel/google-perftools: Perf Tools is a collection of a high-performance multi-threaded malloc() implementation, plus some pretty nifty performance analysis tools. Perf Tools is the fastest memory allocation library available, it also often allows applications to have smaller memory footprint. WWW: http://code.google.com/p/google-perftools PR: ports/113689 Submitted by: Yuri <yuri@tsoft.com> Revision Changes Path 1.2906 +1 -0 ports/devel/Makefile 1.1 +51 -0 ports/devel/google-perftools/Makefile (new) 1.1 +3 -0 ports/devel/google-perftools/distinfo (new) 1.1 +10 -0 ports/devel/google-perftools/pkg-descr (new) 1.1 +76 -0 ports/devel/google-perftools/pkg-plist (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed New port added with some modifications, thanks! TODO: * fix the failing test * fix compilation on amd64