Bug 114569 - [patch] devel/libslang - proper UTF-8 support
Summary: [patch] devel/libslang - proper UTF-8 support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Renato Botelho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-07-14 00:10 UTC by Cristian KLEIN
Modified: 2007-08-31 19:40 UTC (History)
0 users

See Also:


Attachments
file.diff (39.99 KB, patch)
2007-07-14 00:10 UTC, Cristian KLEIN
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cristian KLEIN 2007-07-14 00:10:02 UTC
Currently, devel/libslang has experimental support for UTF-8 through a selectable option. Unfortunately, this does not seem to work, as a hand-compiled and hand-patched misc/mc shows.

The following patch will enable correct UTF-8 support. It is adapted from the Gentoo Portage tree.

Fix: Apply the following patch:

cd /usr/ports/devel
patch -p0 -E < slang.patch

Please remove files/extra-utf8-acs.patch and other .orig files.

Patch attached with submission follows:
How-To-Repeat: Somewhat hard to reproduce. If somebody is interested I will post a follow up.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-07-14 00:10:10 UTC
Responsible Changed
From-To: freebsd-ports-bugs->garga

Over to maintainer
Comment 2 Renato Botelho freebsd_committer freebsd_triage 2007-08-30 17:07:11 UTC
First, sorry for long delay.

Use this patch is really interesting, but, there is a problem, it changes
the library name adding "-utf8" to the name of the file, it's not good
because ports that depend of libslang wouldn't find libs correctly.

Could you please make necessary changes to have libs installed with the
original name?

Thanks for contributing
-- 
Renato Botelho <garga @ FreeBSD.org>
               <freebsd @ galle.com.br>
GnuPG Key: http://www.FreeBSD.org/~garga/pubkey.asc

My theology, briefly, is that the universe was dictated but not signed.
		-- Christopher Morley
Comment 3 Renato Botelho freebsd_committer freebsd_triage 2007-08-30 17:07:31 UTC
State Changed
From-To: open->feedback

Ask for submitter fix.
Comment 4 Cristian KLEIN 2007-08-30 19:11:09 UTC
Hi,

Renato Botelho wrote:
> Use this patch is really interesting, but, there is a problem, it changes
> the library name adding "-utf8" to the name of the file, it's not good
> because ports that depend of libslang wouldn't find libs correctly.

I can vaguely remember that I once encountered this problem, but that I
have corrected it. I have retested the patch and was unable to find this
problem. I have attached a typescript of my session, in which I applied
the patch from zero. Please tell me if you see something unexpected:

Script started on Thu Aug 30 20:55:44 2007
bavaria:/usr/ports# rm -r devel/libslang
bavaria:/usr/ports# make update
[snip]
Updating collection ports-all/cvs
 Checkout ports/devel/libslang/Makefile
 Checkout ports/devel/libslang/distinfo
 Checkout ports/devel/libslang/files/extra-utf8-acs.patch
 Checkout ports/devel/libslang/files/patch-configure
 Checkout ports/devel/libslang/files/patch-src_Makefile.in
 Checkout ports/devel/libslang/pkg-descr
 Checkout ports/devel/libslang/pkg-plist
[snip]
bavaria:/usr/ports# cd devel/libslang
bavaria:/usr/ports/devel/libslang# patch -p1 <
/root/patches/libslang-utf8.patch
[snip all chunks succeded]
bavaria:/usr/ports/devel/libslang# make config
[snip UTF-8 was already enabled]
bavaria:/usr/ports/devel/libslang# make
[snip]
libslang.so.1 created in
/usr/ports/devel/libslang/work/slang-1.4.9/src/elfi386objs.
The link libslang.so to libslang.so.1 was also created.

Use make install-elf to install it.
bavaria:/usr/ports/devel/libslang# make deinstall
===>  Deinstalling for devel/libslang
===>   Deinstalling libslang-1.4.9_1
bavaria:/usr/ports/devel/libslang# make install
[snip]
rm -f /usr/local/lib/libslang.so
installing libslang.so.1 in /usr/local/lib
install  -o root -g wheel -m 444
/usr/ports/devel/libslang/work/slang-1.4.9/src/elfi386objs/libslang.so.1
/usr/local/lib
creating symbolic links to libslang.so.1
cd /usr/local/lib; /bin/ln -sf libslang.so.1 libslang.so

libslang.so.1 created in /usr/local/lib.
The links libslang.so to libslang.so.1 were also created.
[snip]
Script done on Thu Aug 30 20:58:58 2007

> Thanks for contributing

My pleasure.
Comment 5 dfilter service freebsd_committer freebsd_triage 2007-08-31 19:33:06 UTC
garga       2007-08-31 18:33:00 UTC

  FreeBSD ports repository

  Modified files:
    devel/libslang       Makefile distinfo pkg-plist 
  Removed files:
    devel/libslang/files extra-utf8-acs.patch 
  Log:
  - Add UTF8 patch obtained from gentoo, it's more stable than old one
  
  PR:             ports/114569
  Submitted by:   Cristian KLEIN <cristi@net.utcluj.ro>
  
  Revision  Changes    Path
  1.46      +19 -9     ports/devel/libslang/Makefile
  1.19      +6 -6      ports/devel/libslang/distinfo
  1.2       +0 -417    ports/devel/libslang/files/extra-utf8-acs.patch (dead)
  1.19      +4 -1      ports/devel/libslang/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Renato Botelho freebsd_committer freebsd_triage 2007-08-31 19:33:44 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!