Bug 115010 - Improve the actual-package-depends target for bsd.port.mk
Summary: Improve the actual-package-depends target for bsd.port.mk
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-07-29 16:10 UTC by Alexander Leidinger
Modified: 2007-10-03 23:30 UTC (History)
1 user (show)

See Also:


Attachments
bsd.port.mk.diff (1.56 KB, patch)
2007-07-29 16:10 UTC, Alexander Leidinger
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Leidinger freebsd_committer freebsd_triage 2007-07-29 16:10:01 UTC

As nobody complained on the lists, here are the fixes to some issues
with the actual-package-depends target:
 - fix docs to use the right name of the target
 - change the sorting for the packages when used or pgk_create to
   uniquely sort the origin, not the package name (prevents including
   more than one version of the same package in case such a suboptimal
   installation exists)
 - on package list determination check if the origin exists in PORTSDIR,
   skip the current entry if it doesn't exist (if a origin is missing in a old or
   3rd party package, the dependency list is screwed; if a 3rd party
   package doesn't exists while having a origin, this doesn't include it into
   the dependency list, if you have own ports which depend upon
   something like this, you have to create a dummy port/directory for the
   3rd party package)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-07-29 16:10:07 UTC
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

bsd.port.mk is port manager territory
Comment 2 Pav Lucistnik freebsd_committer freebsd_triage 2007-08-01 17:08:59 UTC
State Changed
From-To: open->feedback

This patch breaks all packages that have no dependencies. Their +CONTENTS file contains 

@pkgdep 2 
@pkgdep code 
@pkgdep Error 
@pkgdep ***
Comment 3 Pav Lucistnik freebsd_committer freebsd_triage 2007-08-06 12:43:39 UTC
State Changed
From-To: feedback->open

Missing semicolon; patch edited in-place.
Comment 4 Nate Eldredge 2007-10-03 20:41:35 UTC
Note that without the patch some packages are actually missing 
dependencies.  See ports/115432.  This means it is possible to 
inadvertently uninstall packages which are still depended on, thus 
breaking the dependor.  Thus I think this patch should be applied soon, 
it's not low priority.

-- 

Nate Eldredge
neldredge@math.ucsd.edu
Comment 5 Pav Lucistnik freebsd_committer freebsd_triage 2007-10-03 23:19:15 UTC
State Changed
From-To: open->closed

Committed, thanks!
Comment 6 dfilter service freebsd_committer freebsd_triage 2007-10-03 23:25:06 UTC
pav         2007-10-03 22:25:00 UTC

  FreeBSD ports repository

  Modified files:
    Mk                   bsd.port.mk bsd.xorg.mk 
  Log:
  - Fix issues with actual-package-depends, most notably fix bad list when a
    third party package with invalid or missing pkgorigin is installed; this
    resulted in silently discarding dependency records for some people
  
  PR:             ports/115010
  Submitted by:   netchild
  
  - Replace some calls to basename and dirname with make logic
  
  PR:             ports/115994
  Submitted by:   netchild
  
  - Fix bsd.xorg.mk to work when USE_XORG is used below
    .include <bsd.port.pre.mk>; should allow conditional X.Org component
    dependencies with OPTIONS, etc
  
  Submitted by:   flz
  
  - When installing as user, don't install any libdata/ldconfig entries
  
  Submitted by:   flz
  PR:             ports/106613 (in audit trail)
  
  - Introduce INSTALL_KLD; it's same as INSTALL_SCRIPT but the name is more
    obvious
  
  PR:             ports/116200
  Submitted by:   edwin
  
  Revision  Changes    Path
  1.588     +44 -26    ports/Mk/bsd.port.mk
  1.4       +11 -5     ports/Mk/bsd.xorg.mk
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"