Bug 115198 - [PATCH] security/drweb: update to rcNG script
Summary: [PATCH] security/drweb: update to rcNG script
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-04 16:50 UTC by Jan Srzednicki
Modified: 2007-08-30 16:10 UTC (History)
1 user (show)

See Also:


Attachments
drweb-4.33_4.patch (2.31 KB, patch)
2007-08-04 16:50 UTC, Jan Srzednicki
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Srzednicki 2007-08-04 16:50:01 UTC
Update the port init script to the new rcNG schema.

Added file(s):
- files/drwebd.sh.in

Port maintainer (support@spectrum.ru) is cc'd.

Generated with FreeBSD Port Tools 0.77
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-08-04 16:50:08 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Demin Alexander 2007-08-06 08:51:54 UTC
Hello.

Name of rcNG script is not correct. Correct name is 001.drwebd. The
prefix "001" is necessary because after start drwebd, starting message
filters for sendmail, postfix and others mail daemons. For example:
name of script of sendmail message filter - 002.drweb-smf.sh. 
Please rename rcNG script to 001.drwebd and all be correct.

Thanks for your patch.

-- 
Demin Alexander / Network Administrator
Group of companies Spectrum / tel. (+7 495) 995-8999
Russia, Moscow, 103009, Strastnoy blvr. 8
Comment 3 Jan Srzednicki 2007-08-21 16:02:34 UTC
> Name of rcNG script is not correct. Correct name is 001.drwebd. The
> prefix "001" is necessary because after start drwebd, starting message
> filters for sendmail, postfix and others mail daemons. For example:
> name of script of sendmail message filter - 002.drweb-smf.sh. 
> Please rename rcNG script to 001.drwebd and all be correct.

That's not true. rcNG handles ordering on its own, regardless of file
names and according to the PROVIDE, REQUIRE and BEFORE keywords,
so no filename prefixes are necessary anymore - and they don't work
anyway.

"BEFORE: mail" is enough for any MTA in ports I'm aware of.

-- 
  Jan Srzednicki  ::  http://wrzask.pl/
  "Remember, remember, the fifth of November"
                                     -- V for Vendetta
Comment 4 Jan Srzednicki 2007-08-21 16:09:49 UTC
On Tue, Aug 21, 2007 at 05:02:34PM +0200, Jan Srzednicki wrote:
> > Name of rcNG script is not correct. Correct name is 001.drwebd. The
> > prefix "001" is necessary because after start drwebd, starting message
> > filters for sendmail, postfix and others mail daemons. For example:
> > name of script of sendmail message filter - 002.drweb-smf.sh. 
> > Please rename rcNG script to 001.drwebd and all be correct.
> 
> That's not true. rcNG handles ordering on its own, regardless of file
> names and according to the PROVIDE, REQUIRE and BEFORE keywords,
> so no filename prefixes are necessary anymore - and they don't work
> anyway.
> 
> "BEFORE: mail" is enough for any MTA in ports I'm aware of.

In case of MTA-specific message filter startup scripts, they should be
also replaced according to the rcNG schema, with "REQUIRE: drwebd"
keyword.

But, as the old-style scripts are started AFTER the rcorder-ed ones,
you don't have to do it, as they will be started afterwards anyway.

-- 
  Jan Srzednicki  ::  http://wrzask.pl/
  "Remember, remember, the fifth of November"
                                     -- V for Vendetta
Comment 5 Demin Alexander 2007-08-22 12:49:18 UTC
On Tue, 21 Aug 2007 17:09:49 +0200
Jan Srzednicki <w@wrzask.pl> wrote:

> On Tue, Aug 21, 2007 at 05:02:34PM +0200, Jan Srzednicki wrote:
> > > Name of rcNG script is not correct. Correct name is 001.drwebd. The
> > > prefix "001" is necessary because after start drwebd, starting message
> > > filters for sendmail, postfix and others mail daemons. For example:
> > > name of script of sendmail message filter - 002.drweb-smf.sh. 
> > > Please rename rcNG script to 001.drwebd and all be correct.
> > 
> > That's not true. rcNG handles ordering on its own, regardless of file
> > names and according to the PROVIDE, REQUIRE and BEFORE keywords,
> > so no filename prefixes are necessary anymore - and they don't work
> > anyway.
> > 
> > "BEFORE: mail" is enough for any MTA in ports I'm aware of.
> 
> In case of MTA-specific message filter startup scripts, they should be
> also replaced according to the rcNG schema, with "REQUIRE: drwebd"
> keyword.
> 
> But, as the old-style scripts are started AFTER the rcorder-ed ones,
> you don't have to do it, as they will be started afterwards anyway.
> 

Well, i understend. I approve this patch.
Thanks.

-- 
Demin Alexander / Network Administrator
Group of companies Spectrum / tel. (+7 495) 995-8999
Russia, Moscow, 103009, Strastnoy blvr. 8
Comment 6 Mark Linimon freebsd_committer freebsd_triage 2007-08-22 20:39:29 UTC
State Changed
From-To: feedback->open

Maintainer approved.
Comment 7 dfilter service freebsd_committer freebsd_triage 2007-08-30 16:02:52 UTC
sem         2007-08-30 15:02:47 UTC

  FreeBSD ports repository

  Modified files:
    security/drweb       Makefile pkg-plist 
  Added files:
    security/drweb/files drwebd.sh.in 
  Log:
  - Modern rc.d script
  
  PR:             ports/115198
  Submitted by:   Jan Srzednicki <w@wrzask.pl>
  Approved by:    maintainer
  
  Revision  Changes    Path
  1.54      +2 -3      ports/security/drweb/Makefile
  1.1       +24 -0     ports/security/drweb/files/drwebd.sh.in (new)
  1.27      +1 -2      ports/security/drweb/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 8 Sergey Matveychuk freebsd_committer freebsd_triage 2007-08-30 16:03:12 UTC
State Changed
From-To: open->closed

Committed. Thanks!