Bug 115642 - sysutils/conky build fails due to an undeclared variable
Summary: sysutils/conky build fails due to an undeclared variable
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Roman Bogorodskiy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-20 13:20 UTC by Barbara
Modified: 2007-08-21 19:40 UTC (History)
0 users

See Also:

Attachments
file.diff (604 bytes, patch)
2007-08-20 13:20 UTC, Barbara 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Barbara 2007-08-20 13:20:00 UTC 
Trying to upgrade conky, I got this message:
------------------------------------------------------------------------------
cc -DHAVE_CONFIG_H -I.    -I/usr/local/include  -O2 -pipe -fno-strict-aliasing -march=athlon-mp -I/usr/local/include -I/usr/local/include -D_THREAD_SAFE -I/usr/local/include   -D_THREAD_SAFE -I/usr/local/include   -D_THREAD_SAFE -I/usr/local/include   -D_THREAD_SAFE -I/usr/local/include -I/usr/local/include/freetype2   -Wall -W -MT freebsd.o -MD -MP -MF .deps/freebsd.Tpo -c -o freebsd.o freebsd.c
freebsd.c: In function `get_apm_adapter':
freebsd.c:843: error: `out' undeclared (first use in this function)
freebsd.c:843: error: (Each undeclared identifier is reported only once
freebsd.c:843: error: for each function it appears in.)
freebsd.c: At top level:
..
*** Error code 1

Stop in /usr/ports/sysutils/conky/work/conky-1.4.6/src.
*** Error code 1

Stop in /usr/ports/sysutils/conky/work/conky-1.4.6/src.
*** Error code 1

Stop in /usr/ports/sysutils/conky/work/conky-1.4.6.
*** Error code 1

Stop in /usr/ports/sysutils/conky.
------------------------------------------------------------------------------

Fix: I've modified the file files/patch-src-freebsd.c


Patch attached with submission follows:
How-To-Repeat: cd /usr/ports/sysutils/conky
make WITH_XFT=1 WITHOUT_SETI=1
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-08-20 13:20:09 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->novel

Over to maintainer
Comment 2 Roman Bogorodskiy freebsd_committer freebsd_triage 2007-08-20 14:00:25 UTC 
It builds fine on my FreeBSD box and on tinderbox as well:

http://tb3.droso.net/logs/6-novel/conky-1.4.6.log

Roman Bogorodskiy
Comment 3 Barbara 2007-08-21 00:24:33 UTC 
> It builds fine on my FreeBSD box and on tinderbox as well:
> 
> http://tb3.droso.net/logs/6-novel/conky-1.4.6.log
> 
> Roman Bogorodskiy
>

Platform?
Comment 4 ntarmos 2007-08-21 06:49:47 UTC 
The build may succeed on 6.2 (w/ gcc 3.x) but fails on -current (w/ gcc
4.x). Plus, gcc-isms left aside, use of the undeclared variable 'out' is
an error per my C books.

\n\n
Comment 5 Barbara 2007-08-21 07:28:54 UTC 
> The build may succeed on 6.2 (w/ gcc 3.x) 

You should have looked at my environment ;)

> but fails on -current (w/ gcc 4.x).

...on i386, I guess.

cheers
Comment 6 dfilter service freebsd_committer freebsd_triage 2007-08-21 19:32:04 UTC 
novel       2007-08-21 18:31:59 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/conky/files patch-src-freebsd.c 
  Log:
  Fix build on i386.
  
  PR:             115642
  Submitted by:   Barbara <barbara.xxx1975@libero.it>
  
  Revision  Changes    Path
  1.12      +10 -1     ports/sysutils/conky/files/patch-src-freebsd.c
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Roman Bogorodskiy freebsd_committer freebsd_triage 2007-08-21 19:33:51 UTC 
State Changed
From-To: open->closed

Committed, thanks!