Upon server-initiated closure of the sound device, rdesktop(1) hangs in a tight loop if the sound packet buffer is not empty. This usually occurs after a long playback, and is indicated by an endless stream of "ERROR: select: Bad file descriptor" messages on stderr. Fix: Apply the following patch, which forcibly empties the sound packet buffer after closing the sound device. How-To-Repeat: Run rdesktop with -r sound:local, and play an MP3 file for about 30 seconds then stop playback.
Responsible Changed From-To: freebsd-ports-bugs->obrien Over to maintainer
State Changed From-To: open->feedback Hi Eugene, Have you submitted this patch to the rdesktop project on SourceForge? If so, I'll commit it to the FreeBSD port. Otherwise, could you please report the bug? I'm a little worried your patch is large enough that it could make the next upgrade harder. -- David
Yes, there was already a bug filed for this, to which I submitted the same patch. https://sourceforge.net/tracker/?func=detail&atid=381347&aid=1695146&group_id=24366 is the bug report. Thank you, Eugene
obrien 2007-08-23 23:53:59 UTC FreeBSD ports repository Added files: net/rdesktop/files patch-rdpsnd_oss.c Log: Upon server-initiated closure of the sound device, rdesktop(1) hangs in a tight loop if the sound packet buffer is not empty. This usually occurs after a long playback, and is indicated by an endless stream of "ERROR: select: Bad file descriptor" messages on stderr. Fix: forcibly empty the sound packet buffer after closing the sound device. PR: 115692 Submitted by: "Eugene M. Kim" <freebsd.org@ab.ote.we.lv> Revision Changes Path 1.1 +57 -0 ports/net/rdesktop/files/patch-rdpsnd_oss.c (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Submitter sent patch up-stream, and I committed to /usr/ports.