I updated the R distribution from version 2.5.0 to 2.5.1. In so doing I'm suggesting to add a patch file and some modification in Makefile to fix the directories in which man pages are kept (from /usr/local/share/man/man1 to /usr/local/man/man1). I noticed that those modifications fixed a problem also when preparing a package via 'make package'. Fix: Patch attached with submission follows:
State Changed From-To: open->feedback Awaiting maintainers feedback
Thanks for your submission; it had been so long since the last update, I was I was waiting for 2.6.0 to put one in... ;) You shouldn't have to tinker with the source like you did in your patch: just issue "--mandir=${MANPREFIX}/man" as part of the CONFIGURE_ARGS in the port Makefile. Since the existing port Makefile already has GNU_CONFIGURE=yes, this should be issued automatically, but for some reason in line 58 of the existing Makefile, the author used "CONFIGURE_ARGS=" instead of "CONFIGURE_ARGS+=", wiping out the default CONFIGURE_ARGS. I think this should be changed to "CONFIGURE_ARGS+=". By setting MANCOMPRESSED to the appropriate value in the Makefile, you should obviate the need for explicitly issuing commands to compress manpages. See: http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-manpages.html bf ____________________________________________________________________________________ Looking for a deal? Find great prices on flights and hotels with Yahoo! FareChase. http://farechase.yahoo.com/
Responsible Changed From-To: freebsd-ports-bugs->rafan I'll take it.
Enclosed please find the patch I intend to commit. It's tested in my tinderbox. The path for manual page is correct, no need to patch.
It seems your ports tree is out-of-date. Please make sure your Makefile is # $FreeBSD: ports/math/R/Makefile,v 1.63 2007/07/23 09:36:10 rafan Exp $
I took into account all your observations. In my box FreeBSD hpbsd.vic 6.2-RELEASE-p6 FreeBSD 6.2-RELEASE-p6 #1 I I had some problems with the man pages that where installed always under ${PREFIX}/share/man/man1 and uncompressed. Now the following patch seems to fix this and some other minor faults in pkg-plist. Ciao from Rome Vittorio
Rong-En Fan wrote: > Enclosed please find the patch I intend to commit. > It's tested in my tinderbox. The path for manual page > is correct, no need to patch. Wow, that's a very small diff! Please commit it. Thank you for your work. Eric
rafan 2007-08-27 12:38:22 UTC FreeBSD ports repository Modified files: math/R Makefile distinfo pkg-plist Log: - Update to 2.5.1 PR: ports/115826 (based on) Submitted by: vittorio de martino <vdemart1 at tin.it> Approved by: Eric van Gyzen <eric+fbports at vangyzen.net> (maintainer) Revision Changes Path 1.64 +1 -1 ports/math/R/Makefile 1.32 +3 -3 ports/math/R/distinfo 1.36 +4 -2 ports/math/R/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed. Thanks!