Update port sysutils/downtime to version 0.3.1. Changes: - Correct passing of parameters to shutdown(8) - Correct a bug whereby attempting to set preferences when no configuration file already exists (e.g., when first running DownTime) would result in a warning and non-application / saving of the new preferences - Window title consistency - Print date and time when writing warnings / errors If it's possible and practical for the downtime-0.3.1.tar.gz file to be hosted somewhere other than just on my personal web server, it'd be fantastic, too! Fix: PORTNAME= downtime -PORTVERSION= 0.3.0 +PORTVERSION= 0.3.1 CATEGORIES= sysutils MASTER_SITES= http://www.nickwithers.com/downtime/
Andrew Pantyukhin (sat@) wisely pointed out that the share/applications directory should probably be @dirrmtry'ed. As such, please find attached an updated patch to both move sysutils/downtime to 0.3.1 and address this issue (thanks Andrew!). Ta, and my apologies for missing this in the first place! -- Nick Withers email: nick@nickwithers.com Web: http://www.nickwithers.com Mobile: +61 414 397 446
Responsible Changed From-To: freebsd-ports-bugs->tmclaugh Grab
Attached is a patch to the Makefile included with the distfile. Do you want to just reroll the tarball with this included? I changed the X11BASE usage to PREFIX to make the install prefix safe. I also created share/applications ahead of installing the .desktop file so package building doesn't fail. I also removed the USE_X_PREFIX line from the port since it's no longer relevant. Thanks. tom
State Changed From-To: open->feedback Waiting maintainer feedback.
On Tue, 4 September, 2007 5:27 am, Tom McLaughlin wrote: > Attached is a patch to the Makefile included with the distfile. Do you > want to just reroll the tarball with this included? I changed the > X11BASE usage to PREFIX to make the install prefix safe. Nice, thanks. I actually had a look at the Makefile and changed a few more things (like actually removing the downtime.desktop file... Oh dear!). Could I actually ask that you cast your eye over it before I roll a new tarball (please see attached)? I really haven't quite mastered the art of Makefiles! > I also created share/applications ahead of installing the .desktop file > so package building doesn't fail. I'm somewhat curious about this as I was able to "make package" without problems... > I also removed the USE_X_PREFIX line from the port since it's no longer > relevant. Good call, cheers. > Thanks. Ta for your help! > tom -- Nick Withers email: nick@nickwithers.com Web: http://www.nickwithers.com Mobile: +61 414 397 446
State Changed From-To: feedback->open Feedback received
State Changed From-To: open->feedback I'm not the greatest with Makefiles outside of port Makefiles but the one thing I did notice was the `rm -d` usage in your deinstall. Use rmdir instead since -d doesn't exist in all versionbs of rm out there. The reason the port fails package building in my tinderbox is because on a totally clean system share/applications won't exist so the file can't be instaled there. Let me know when you reroll the distfile so I can update the port.
Righto, I've attached a diff from the current sysutils/downtime to version 0.3.1.1. Thanks for your help! -- Nick Withers email: nick@nickwithers.com Web: http://www.nickwithers.com Mobile: +61 414 397 446
tmclaugh 2007-09-17 18:29:31 UTC FreeBSD ports repository Modified files: sysutils/downtime Makefile distinfo Added files: sysutils/downtime pkg-plist Log: Update to 0.3.1.1 - Makefile fixes. - Correct passing of parameters to shutdown(8) - Correct a bug whereby attempting to set preferences when no configuration file already exists (e.g., when first running DownTime) would result in a warning and non-application saving of the new preferences - Window title consistency - Print date and time when writing warnings / errors PR: 115852 Submitted by: maintainer Revision Changes Path 1.5 +1 -5 ports/sysutils/downtime/Makefile 1.4 +3 -3 ports/sysutils/downtime/distinfo 1.1 +3 -0 ports/sysutils/downtime/pkg-plist (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed 0.3.1.1 patch committed after tinderboxing just fine.