Bug 115994 - remove the use of basename and dirname calls in bsd.port.mk
Summary: remove the use of basename and dirname calls in bsd.port.mk
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-01 13:40 UTC by Alexander Leidinger
Modified: 2007-10-03 23:30 UTC (History)
1 user (show)

See Also:


Attachments
remove_basename_call.diff (4.91 KB, patch)
2007-09-01 13:40 UTC, Alexander Leidinger
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Leidinger freebsd_committer freebsd_triage 2007-09-01 13:40:00 UTC

There are some uses of basename and dirname in bsd.port.mk. They can be replaced by makefile logic instead of exec()ing basename or dirname.

I haven't tested the performance impact/improvement.

Included are also 3 style fixes (whitespace).
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-09-01 13:40:09 UTC
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

bsd.port.mk is portmgr territory
Comment 2 Pav Lucistnik freebsd_committer freebsd_triage 2007-10-03 23:21:10 UTC
State Changed
From-To: open->closed

Committed, thanks!
Comment 3 dfilter service freebsd_committer freebsd_triage 2007-10-03 23:25:06 UTC
pav         2007-10-03 22:25:00 UTC

  FreeBSD ports repository

  Modified files:
    Mk                   bsd.port.mk bsd.xorg.mk 
  Log:
  - Fix issues with actual-package-depends, most notably fix bad list when a
    third party package with invalid or missing pkgorigin is installed; this
    resulted in silently discarding dependency records for some people
  
  PR:             ports/115010
  Submitted by:   netchild
  
  - Replace some calls to basename and dirname with make logic
  
  PR:             ports/115994
  Submitted by:   netchild
  
  - Fix bsd.xorg.mk to work when USE_XORG is used below
    .include <bsd.port.pre.mk>; should allow conditional X.Org component
    dependencies with OPTIONS, etc
  
  Submitted by:   flz
  
  - When installing as user, don't install any libdata/ldconfig entries
  
  Submitted by:   flz
  PR:             ports/106613 (in audit trail)
  
  - Introduce INSTALL_KLD; it's same as INSTALL_SCRIPT but the name is more
    obvious
  
  PR:             ports/116200
  Submitted by:   edwin
  
  Revision  Changes    Path
  1.588     +44 -26    ports/Mk/bsd.port.mk
  1.4       +11 -5     ports/Mk/bsd.xorg.mk
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"