Bug 116972 - audio/Amarok broken due to newer version of mpeg4ip-libmp4v2
Summary: audio/Amarok broken due to newer version of mpeg4ip-libmp4v2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Michael Landin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-06 10:30 UTC by Armin Pirkovitsch
Modified: 2007-10-14 20:00 UTC (History)
0 users

See Also:

Attachments
file.diff (570 bytes, patch)
2007-10-06 10:30 UTC, Armin Pirkovitsch 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Armin Pirkovitsch 2007-10-06 10:30:02 UTC 
In the previous version of the above mentioned library MP4Close was a bool method.
However it has been changed to void (error handling done internally by exceptions now)
Due to this change amarok won't compile any more because it can't convert void to bool.

Fix: The attached file is an altered patch to also fix this problem.

Patch attached with submission follows:
How-To-Repeat: try to compile amarok with the newest version of mpeg4ip-libmp4v2
Comment 1 Stefan Walter freebsd_committer freebsd_triage 2007-10-06 17:49:15 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->mich

Assign to maintainer.
Comment 2 dfilter service freebsd_committer freebsd_triage 2007-10-14 19:58:44 UTC 
mich        2007-10-14 18:58:37 UTC

  FreeBSD ports repository

  Modified files:
    audio/amarok/files   patch-amarok_src_metadata_mp4_mp4file.cpp 
  Log:
  - fix breakage from lastest mpeg4ip-libmp4v2
  
  PR:             ports/116972
  Submitted by:   Armin Pirkovitsch <a.pirko@inode.at>
  
  Revision  Changes    Path
  1.2       +14 -1     ports/audio/amarok/files/patch-amarok_src_metadata_mp4_mp4file.cpp
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Michael Landin freebsd_committer freebsd_triage 2007-10-14 20:00:20 UTC 
State Changed
From-To: open->closed

Committed, thanks!