Bug 117507 - bsd.port.mk - Allow tab as well as space in param.h for OSVERSION determination
Summary: bsd.port.mk - Allow tab as well as space in param.h for OSVERSION determination
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-25 19:20 UTC by Erwin Lansing
Modified: 2008-03-11 23:50 UTC (History)
0 users

See Also:


Attachments
bpm-space.diff (867 bytes, patch)
2007-10-25 19:20 UTC, Erwin Lansing
no flags Details | Diff
bpm-space.diff (1.70 KB, patch)
2007-10-25 19:53 UTC, Erwin Lansing
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erwin Lansing freebsd_committer freebsd_triage 2007-10-25 19:20:02 UTC
Recently, "#define __FreeBSD_version" was committed with a tab
instead of a space between those words, which breaks OSVERSION
determination.  Change the awk(1) line to [[:blank:]] over ' '.

How-To-Repeat: 
Edit param.h to include a tab:
Current:
erwin@rabbit:sys/sys> awk '/^#define __FreeBSD_version/ {print $3}' < param.h
erwin@rabbit:sys/sys> 
With patch:
erwin@rabbit:sys/sys> awk '/^#define[[:blank:]]__FreeBSD_version/ {print $3}' < param.h
800003
Comment 1 Erwin Lansing freebsd_committer freebsd_triage 2007-10-25 19:53:24 UTC
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

Schedule for an -exp build.
Comment 2 Erwin Lansing freebsd_committer freebsd_triage 2007-10-25 19:53:50 UTC
Updated patch to include the same fix in bsd.port.subdir.mk

Comment 3 Pav Lucistnik freebsd_committer freebsd_triage 2008-03-11 23:40:22 UTC
State Changed
From-To: open->closed

Committed, thanks!
Comment 4 dfilter service freebsd_committer freebsd_triage 2008-03-11 23:45:10 UTC
pav         2008-03-11 23:45:04 UTC

  FreeBSD ports repository

  Modified files:
    Mk                   bsd.port.mk bsd.port.subdir.mk 
                         bsd.xorg.mk 
  Log:
  - Automatically append -fno-strict-aliasing to CFLAGS when -O2 or higher
    optimizations are enabled.
  
  PR:             ports/121363
  Submitted by:   obrien
  
  - Change USE_XPM variable to use USE_XORG framework, and lose implied USE_XLIB
  
  PR:             ports/113799
  Submitted by:   des (based on)
  Patch by:       pav
  
  - Teach USE_LDCONFIG to do the right thing when used with USE_LINUX_PREFIX
  
  PR:             ports/118212
  Original patch: vd
  Patch by:       pav
  
  - Allow tab as well as space in param.h for OSVERSION determination
  
  PR:             ports/117507
  Submitted by:   erwin
  
  - Reverse the condition so EXTRACT_PRESERVE_OWNERSHIP now work as advertised
  
  PR:             ports/117916
  Submitted by:   tobez
  
  - Assorted comment fixes
  
  PR:             ports/118054
  Submitted by:   linimon
  
  - Style nit ($@ -> ${.TARGET})
  
  PR:             ports/120276
  Submitted by:   obrien
  
  Revision  Changes    Path
  1.591     +38 -14    ports/Mk/bsd.port.mk
  1.73      +3 -3      ports/Mk/bsd.port.subdir.mk
  1.5       +2 -8      ports/Mk/bsd.xorg.mk
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"