Bug 117691 - [patch] audio/nosefart fix build with gcc 4.2
Summary: [patch] audio/nosefart fix build with gcc 4.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-30 22:10 UTC by Pietro Cerutti
Modified: 2007-10-31 10:05 UTC (History)
0 users

See Also:

Attachments
file.diff (1.48 KB, patch)
2007-10-30 22:10 UTC, Pietro Cerutti 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pietro Cerutti 2007-10-30 22:10:01 UTC 
audio/nosefart fails to build with gcc 4.2 because of a cast used where an lvalue is required

Fix: The following patch removes the BROKEN message from the port's Makefile and adds a patch to files/patch-src-sndhrdw-nes_apu.c which fixes the actual lvalue problem.

How-To-Repeat: cd /usr/ports/audio/nosefart && make
Comment 1 Martin Wilke freebsd_committer freebsd_triage 2007-10-30 22:43:51 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->miwi

I'll take it.
Comment 2 Martin Wilke freebsd_committer freebsd_triage 2007-10-31 00:19:05 UTC 
State Changed
From-To: open->closed

Committed. Thanks!
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2007-10-31 04:34:49 UTC 
State Changed
From-To: closed->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Seth Kingsley 2007-10-31 05:10:09 UTC 
Patch looks good to me.  Please commit.
Comment 5 dfilter service freebsd_committer freebsd_triage 2007-10-31 06:05:08 UTC 
miwi        2007-10-31 00:18:52 UTC

  FreeBSD ports repository

  Modified files:
    audio/nosefart       Makefile 
  Added files:
    audio/nosefart/files patch-src-sndhrdw-nes_apu.c 
  Log:
  - Fix build with gcc 4.2
  
  PR:             117691
  Submitted by:   Pietro Cerutti (gahr@gahr.ch)
  Approved by:    portmgr (erwin)
  
  Revision  Changes    Path
  1.10      +1 -7      ports/audio/nosefart/Makefile
  1.1       +25 -0     ports/audio/nosefart/files/patch-src-sndhrdw-nes_apu.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Martin Wilke freebsd_committer freebsd_triage 2007-10-31 10:05:07 UTC 
State Changed
From-To: feedback->closed

Committed. Thanks!