Bug 117749 - [patch] editors/cooledit unbreak fix build with GCC 4.2
Summary: [patch] editors/cooledit unbreak fix build with GCC 4.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-02 00:00 UTC by Pietro Cerutti
Modified: 2007-11-05 10:20 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pietro Cerutti 2007-11-02 00:00:02 UTC 
A "static declaration follows non static declaration" problem for the function run_callbacks exist between the header file ${WRKSRC}/coollocal.h and the module ${WRKSRC}coolnext.c.
Since run_callbacks is only used within coolnext.c, I see no reason to keep the declaration in coollocal.h.

Fix: 

The link to the patch comes in my next follow-up.
How-To-Repeat: cd /usr/ports/editors/cooledit && make
Comment 1 Pietro Cerutti 2007-11-02 00:02:56 UTC 
The patch:
http://www.gahr.ch/FreeBSD/patches/117749_cooledit.diff

-- 
Pietro Cerutti

PGP Public Key:
http://gahr.ch/pgp
Comment 2 Martin Wilke freebsd_committer freebsd_triage 2007-11-02 00:02:57 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->miwi

I'll take it.
Comment 3 Martin Wilke freebsd_committer freebsd_triage 2007-11-05 10:15:43 UTC 
State Changed
From-To: open->closed

Committed. Thanks!
Comment 4 dfilter service freebsd_committer freebsd_triage 2007-11-05 10:16:00 UTC 
miwi        2007-11-05 10:15:52 UTC

  FreeBSD ports repository

  Modified files:
    editors/cooledit     Makefile 
  Added files:
    editors/cooledit/files patch-widget-coollocal.h 
  Log:
  - Fix build with gcc 4.2
  
  PR:             117749
  Submitted by:   pietro cerutti <gahr@gahr.ch>
  Approved by:    portmgr (pav)
  
  Revision  Changes    Path
  1.58      +1 -7      ports/editors/cooledit/Makefile
  1.1       +10 -0     ports/editors/cooledit/files/patch-widget-coollocal.h (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"