Bug 117826 - [PATCH] audio/oss: fix plist and unbreak
Summary: [PATCH] audio/oss: fix plist and unbreak
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jung-uk Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-04 21:10 UTC by Yen-Ming Lee
Modified: 2007-11-13 16:04 UTC (History)
1 user (show)

See Also:


Attachments
oss-4.0.b1008.patch (1.99 KB, patch)
2007-11-04 21:10 UTC, Yen-Ming Lee
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yen-Ming Lee 2007-11-04 21:10:01 UTC
- fix plist
- patch and unbreak on 5.x

Port maintainer (jkim@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.77
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-11-04 21:10:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->jkim

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Pav Lucistnik freebsd_committer freebsd_triage 2007-11-07 01:14:11 UTC
Then it has to be removed by pkg-deinstall or by @exec in pkg-plist.

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>
The number you dialed is imaginary. Please turn your phone by 90 degrees
and try again.
Comment 3 Jung-uk Kim freebsd_committer freebsd_triage 2007-11-07 16:46:01 UTC
On Tuesday 06 November 2007 08:50 pm, Pav Lucistnik wrote:
> The following reply was made to PR ports/117826; it has been noted
> by GNATS.
>
> From: Pav Lucistnik <pav@FreeBSD.org>
> To: bug-followup@FreeBSD.org
> Cc:
> Subject: Re: ports/117826: [PATCH] audio/oss: fix plist and unbreak
> Date: Wed, 07 Nov 2007 02:14:11 +0100
>
>  Then it has to be removed by pkg-deinstall or by @exec in
> pkg-plist.

The file contains user configurable settings.  I didn't want to remove 
it during upgrades:

http://docs.freebsd.org/cgi/mid.cgi?200710121613.l9CGDEHi062480

Jung-uk Kim
Comment 4 Pav Lucistnik freebsd_committer freebsd_triage 2007-11-07 23:48:43 UTC
Jung-uk Kim pí¹e v st 07. 11. 2007 v 11:46 -0500:
> On Tuesday 06 November 2007 08:50 pm, Pav Lucistnik wrote:
> > The following reply was made to PR ports/117826; it has been noted
> > by GNATS.
> >
> > From: Pav Lucistnik <pav@FreeBSD.org>
> > To: bug-followup@FreeBSD.org
> > Cc:
> > Subject: Re: ports/117826: [PATCH] audio/oss: fix plist and unbreak
> > Date: Wed, 07 Nov 2007 02:14:11 +0100
> >
> >  Then it has to be removed by pkg-deinstall or by @exec in
> > pkg-plist.
> 
> The file contains user configurable settings.  I didn't want to remove 
> it during upgrades:
> 
> http://docs.freebsd.org/cgi/mid.cgi?200710121613.l9CGDEHi062480


You have to remove it, one way or another, otherwise the port is
unacceptable. You could remove it if it's identical to the originally
installed file (ie no user changes).

Also, gets that file created when installed from package?

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>
And now something completely different.
Comment 5 dfilter service freebsd_committer freebsd_triage 2007-11-13 15:59:10 UTC
jkim        2007-11-13 15:59:06 UTC

  FreeBSD ports repository

  Modified files:
    audio/oss            Makefile pkg-plist 
    audio/oss/files      patch-kernel-OS-FreeBSD-os_freebsd.c 
  Added files:
    audio/oss/files      pkg-deinstall.in 
  Log:
  - Unbreak build on 5.x.[1]
  - Remove userdefs if it is unchanged or empty.
  
  PR:             ports/117826
  Reported by:    pointyhat
  Submitted by:   Yen-Ming Lee (leeym at leeym dot com)[1]
  Approved by:    portmgr (linimon)
  
  Revision  Changes    Path
  1.15      +2 -5      ports/audio/oss/Makefile
  1.2       +11 -3     ports/audio/oss/files/patch-kernel-OS-FreeBSD-os_freebsd.c
  1.1       +17 -0     ports/audio/oss/files/pkg-deinstall.in (new)
  1.7       +0 -1      ports/audio/oss/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Jung-uk Kim freebsd_committer freebsd_triage 2007-11-13 16:01:00 UTC
State Changed
From-To: open->closed

Unbreak 5.x part is committed as is and userdefs is done 
from pkg-deinsall now.  Thanks!