I'm proposing a diff file to update R from 2.6.0 to 2.6.1 Fix: Patch attached with submission follows:
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Vittorio, Thanks for your patch. It looks good, but I have some suggestions. The patch removes several %%FOO%% prefixes from the pkg-plist, such as: -%%TCLTK%%lib/R/library/tcltk/libs/tcltk.so +lib/R/library/tcltk/libs/tcltk.so The %%FOO%% prefixes exist to support the Makefile's OPTIONS; they should not be removed. See: http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-options.html There are a few @dirrm lines that should not change %%DOCSDIR%% to share/doc. The man pages need not be specified in the pkg-plist; the MAN1 variable in the Makefile handles them. Thanks for your work! I'll gladly review a revised patch. Eric
Responsible Changed From-To: freebsd-ports-bugs->rafan I'll take it.
State Changed From-To: feedback->closed Committed, with minor changes. Thanks!
rafan 2008-02-26 01:57:12 UTC FreeBSD ports repository Modified files: math/R Makefile distinfo pkg-plist Log: - Update to 2.6.1 PR: ports/118358 Submitted by: Vittorio De Martino <vdemart1 at tin.it> Approved by: Eric van Gyzen <eric+fbports at vangyzen.net> (maintainer) Revision Changes Path 1.67 +1 -1 ports/math/R/Makefile 1.34 +3 -3 ports/math/R/distinfo 1.38 +21 -4 ports/math/R/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"